Ticket #10002 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix Windows tests in debug mode

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 3.3
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Martyn Gigg) (diff)

​http://builds.mantidproject.org/view/Develop%20Builds/job/develop_clean_win7_debug/15/console shows that we have some failing tests in debug mode on Windows.

There are also tests in doctests that are failing too:

  • ViewBOA
  • FixGSASInstrumentFile
  • SortDetectors
  • GenerateEventsFilter

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Set the PATH to ParaView based on the build configuration on windows

Trying to run a debug build with a release version of ParaView causes the Vates API tests to fail. Refs #10002

Changeset: a1a0cbe1b3ae863b26ef205b3510b807933d1277

comment:3 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)

comment:4 Changed 6 years ago by Martyn Gigg

Set the PATH to ParaView based on the build configuration on windows

Trying to run a debug build with a release version of ParaView causes the Vates API tests to fail. Refs #10002

Changeset: a1a0cbe1b3ae863b26ef205b3510b807933d1277

comment:5 Changed 6 years ago by Martyn Gigg

Fix vector resize bug in LoadFlexiNexus

Refs #10002

Changeset: f08ae1f2f6d74712a23189d441961d1c0d2b2b38

comment:6 Changed 6 years ago by Martyn Gigg

Run MantidPlot tests in the correct configuration.

Refs #10002

Changeset: d19a7ac40baf045d2bd662e771eb27f379bd1b32

comment:7 Changed 6 years ago by Michael Wedel

Re #10002. Fixing PoldiPeakSearch problem with invalid iterators.

Changeset: 5e0b811eec618b301904a3a04b797b52a76f3d1e

comment:8 Changed 6 years ago by Martyn Gigg

Fix two usage examples on Windows.

The numpy.shape print in windows printed (0L,) and not (0,) due to the different representations on the different platforms.

Refs #10002

Changeset: 889cdcfde7cca88bd96865172b01318729838ab9

comment:9 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.3

comment:10 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: ​bugfix/10002_fix_tests_win_debug

Tester: The ​windows debug build should now be passing. If you want to you can build everything locally in debug on windows and run the unit tests & doc tests.

comment:11 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Priority changed from major to blocker
  • Resolution fixed deleted
  • Description modified (diff)

comment:12 Changed 6 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

Fix indexing error in GenerateEventsFilter.

Refs #10002

Changeset: 04cf2ace6e10f00509af9509a411b5d3e1f0491a

comment:13 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Things are looking much better now: ​http://builds.mantidproject.org/view/Develop%20Builds/job/develop_clean_win7_debug/

comment:14 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:15 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10002_fix_tests_win_debug'

Full changeset: ​ceb5716e13878e4f6bfc1a1c2762ecde8e8f9835

comment:16 Changed 6 years ago by Owen Arnold

Tests passing. All changes make sense. Good to have this back up and running again.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10844

Note: See TracTickets for help on using tickets.