Ticket #10032 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Refactor Vesuvio resolution to separate fit function.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: #10009 Tester: Martyn Gigg

Description (last modified by Samuel Jackson) (diff)

Separate the resolution code from the ComptonProfile class into a separate fit function. This should include a method that still allows the ComptonProfile class to cache the resolution parameters.

Attachments

res.py​ (1.7 KB) - added by Samuel Jackson 6 years ago.
Testing script for resolution function.
resolution.png​ (23.8 KB) - added by Samuel Jackson 6 years ago.
Resolution screenshot

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

  • Blocking 10009 added

comment:3 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #10032 Add fit function for Vesuvio resolution.

Changeset: 1fc2000ff7faf5dc87a18e6166beeb829c4f5ade

comment:4 Changed 6 years ago by Samuel Jackson

Refs #10032 Swap ComptonProfile to use VesuvioResolution function.

Changeset: 51c8cbd9a1bb32ed4bd3f2aaf639bfa6ddfbe6c8

comment:5 Changed 6 years ago by Samuel Jackson

Refs #10032 Tidy up.

Changeset: a89e94520d32961aff99e9b77d280b637c0eb555

Changed 6 years ago by Samuel Jackson

Testing script for resolution function.

Changed 6 years ago by Samuel Jackson

Resolution screenshot

comment:6 Changed 6 years ago by Samuel Jackson

Refs #10032 Fix Doxygen warnings on develop.

Changeset: 2f67dec947be81859aa62bc2c6a3cb9d912f6195

comment:7 Changed 6 years ago by Samuel Jackson

  • Description modified (diff)

To Test

I've added a testing script which can be used to run the function independently. Check that the _resolution workspace created by the script matches the screenshot provided. Then do a code review. The unit and system tests should verify that the function is working correctly with the rest of the ComptonProfile code.

Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:8 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 6 years ago by Martyn Gigg

Looks good. I made a slight modification to the script to keep workspaces out of the ADS and only add the one we want but this doesn't need any changes to the C++ code.

comment:11 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10032_refactor_vesuvio_resoltuion'

Full changeset: ​e9cc7a9f48945ca4628e5388befe8c21cce05ca0

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10874

Note: See TracTickets for help on using tickets.