Indirect algorithm: IndirectTrans

[Dan Nixon]

Convert this script into a Python algorithm with suitable unit testing.

[Dan Nixon]

Moved script to IndirectTrans algorithm

Refs #10057

Changeset: 4e1082ff4adbdb56bb8fe08b118dad347c02a2ab

[Dan Nixon]

Fixed some issues in IndirectTrans algorithm, add test

Added unit test and required test data

Refs #10057

Changeset: 696900be889833ed3b91ed74b5ac868be12716c7

[Dan Nixon]

Gave IndirectTrans a more meaningful name, added docs

Refs #10057

Changeset: a33257f781d4a449991404423e844764bc6b0a27

[Dan Nixon]

Fix broken Python tests CMakeList

Refs #10057

Changeset: 3e6f75500754dcce90385f03c63b63cdfafe6eb3

[Dan Nixon]

Merge branch 'bugfix/10057_indirecttrans_python_algorithm' into develop

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt

Refs #10057

Changeset: 408190d86cb865d5d9c9c4724af8f24a8a1e3418

[Dan Nixon]

To test, attempt to use the Transmission tab in Indirect Data Reduction, resulting transmission workspace should be identical to one produced by an earlier version of Mantid (e.g. 3.2).

Verify that the algorithm is in appropriate categories and the help file is suitable.

[Martyn Gigg]

It looks like the category name has a spelling error that has caused a systemtest to fail:

​http://builds.mantidproject.org/job/develop_systemtests_rhel6/lastCompletedBuild/testReport/SystemTests/SphinxWarnings/SphinxWarnings/

[Dan Nixon]

Corrected typo which broke system tests

Refs #10057

Changeset: 66749a9f8c89749f2f9b1a1dd2ffaec99f1e6c74

[Dan Nixon]

Looking at this again I doubt plotting from inside an algorithm is a good idea, will move this back to the UI.

[Dan Nixon]

Added file properties for algorithm input files

Refs #10057

Changeset: 05d83dcb62fe5f4f17e03a8a37907278e7fcec34

[Dan Nixon]

I'm not sure if there is a standard way to create a plot form a custom interface, a lot of the time I see Python being used for this.

I have left the plotting in the algorithm for now.

[Dan Nixon]

Catch correct exception type in unit test

Refs #10057

Changeset: f757c606c0c3b7ffaf43f04eda1282efdf67c75e

[Dan Nixon]

Updated IndirectTransmissionMonitor to use workspaces

Refs #10057

Changeset: e3fb9eeca7212f48156ce8ef68aaf9a87b4e6282

[Dan Nixon]

Improved documentation and unit test

Refs #10057

Changeset: 9778c8e835226c4f929d564576b8d5bf5ab592dd

[Dan Nixon]

Merge branch 'bugfix/10057_indirecttrans_python_algorithm' into develop

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt

Refs #10057

Changeset: 408190d86cb865d5d9c9c4724af8f24a8a1e3418

[Dan Nixon]

TODO: Spencer has noted that the can workspace name should be added to the sample logs of the output workspace.

[Dan Nixon]

Merge branch 'master' into bugfix/10057_indirecttrans_python_algorithm

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py

Refs #10057

Changeset: 27ff22bf0f62cc1a395e9706451aa468250fdede

[Dan Nixon]

Refactoring, add can_workspace to trans. workspace logs

Refs #10057

Changeset: fced160c17a89d9dabd239a085fedf6be6b9d342

[Dan Nixon]

Added data selectors to trans UI

Refs #10057

Changeset: 422979c70a57252e34dfe350afe69ff2e391605b

[Dan Nixon]

Merge branch 'bugfix/10057_indirecttrans_python_algorithm' into develop

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataReduction.ui

Refs #10057

Changeset: 910d742427996ba5dcbcd648c61ad4d8358bc601

[Dan Nixon]

Try to get index of monitors and first detectior using IDF

Refs #10057

Changeset: 8da2aeafafb46297b7cfb95b7f1468d98f2a5df9

[Dan Nixon]

Fix unit test for RHEL6

Refs #10057

Changeset: 3a0dfab9a17fb188e2bdcf7bcabff946c4c81f25

[Dan Nixon]

Added compatability with instruments with only one monitor

e.g. TOSCA

Refs #10057

Changeset: 6076b9a2933bcb4f06c6e9e2629c7f7f5d15f322

[Dan Nixon]

Fix typo in transmission monitor usage example

Refs #10057

Changeset: b366ab8e7b0564b20b71afb813a9ba42801759e4

[Dan Nixon]

Added output naming testing to unit test

Refs #10057

Changeset: a35419372faaa5d9166908c1bf113c8dbb9eb087

[Dan Nixon]

Set literals don't exist in Python 2.6

Refs #10057

Changeset: 73929f7e81a8345f3a7a22069d184cae4aa02111

[Dan Nixon]

To test:

• Ensure system test ISISIndirectInelasticTransmissionMonitor is passing
• Open Indirect > Data Reduction > Transmission and run with sample IRS26176 and can IRS26173
• Ensure the can workspace appears in th sample logs
• Play with the output options and ensure they work as intended

Note that there are changes to systemtests with this ticket.

[Dan Nixon]

Merge branch 'master' into bugfix/10057_indirecttrans_python_algorithm

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py

Refs #10057

Full changeset: ​27ff22bf0f62cc1a395e9706451aa468250fdede

[Anders Markvardsen]

Merge remote-tracking branch 'origin/bugfix/10057_indirecttrans_python_algorithm'

Full changeset: ​6e1a45e71131a98a71181108d8340da16777e8ee

[Anders Markvardsen]

Merge remote-tracking branch 'origin/bugfix/10057_indirecttrans_python_algorithm'

Full changeset: ​fa5c8960722d49a64af9940fb762d072e84f5a59

[Dan Nixon]

Merge branch 'master' into bugfix/10057_indirecttrans_python_algorithm

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py

Refs #10057

Full changeset: ​27ff22bf0f62cc1a395e9706451aa468250fdede

[Anders Markvardsen]

Merge remote-tracking branch 'origin/bugfix/10057_indirecttrans_python_algorithm'

Full changeset: ​6e1a45e71131a98a71181108d8340da16777e8ee

[Stuart Campbell]

This ticket has been transferred to github issue ​10899