Ticket #10068 (closed: fixed)
PlotAsymmetryByLogValue warn/stop if runs not from same directory
| Reported by: | Anders Markvardsen | Owned by: | Raquel Alvarez Banos |
|---|---|---|---|
| Priority: | minor | Milestone: | Backlog |
| Component: | Muon | Keywords: | |
| Cc: | Blocked By: | #10894 | |
| Blocking: | Tester: | Federico M Pouzols |
Description
Warn if runs are beeing picked from different directories when using PlotAsymmetryByLogValue. And try to correct this on the fly where possible.
This currently can accidently happen and when happens it is very confusing to debug
Change History
comment:3 Changed 6 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Raquel Alvarez Banos
- Priority changed from major to minor
Note PlotAsymmetryByLogValue is used by the ALC interface although this algorihtm can be used independent of the ALC interface also
comment:5 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from assigned to inprogress
Re #10068 Search for first/last run in the other directory
Changeset: 91d9053169f668ebfb04ccdd739ea0d4c61ea377
comment:6 Changed 6 years ago by Raquel
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #282.
comment:7 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:8 Changed 6 years ago by Federico M Pouzols
Seems to work. If I put partial sets of runs in different directories I get an error message 'First and last runs are not in the same directory'. If I put all the files in the (different) location of the last run file, it finds them there.
But it doesn't show a warning, which I understand was the initial plan in the ticket. Is it fine like this? Otherwise I think this can be merged.
comment:9 Changed 6 years ago by Raquel Alvarez Banos
Re #10068 Adding warning message
Changeset: 5c8849fb29b1995ce198d4c0ce3e3abd665489a5
comment:10 Changed 6 years ago by Raquel
Thanks Federico. Warning messages have been added to the code.
comment:11 Changed 6 years ago by Federico M Pouzols
It now shows a warning message and everything looks good.
comment:12 Changed 6 years ago by Raquel Alvarez Banos
Re #10068 Search for first/last run in the other directory
Changeset: 91d9053169f668ebfb04ccdd739ea0d4c61ea377
comment:13 Changed 6 years ago by Raquel Alvarez Banos
Re #10068 Adding warning message
Changeset: 5c8849fb29b1995ce198d4c0ce3e3abd665489a5
comment:14 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #282 from mantidproject/10068_Stop_if_bad_run_names
Search for first/last run in the other directory
Full changeset: d1e5ad22140283b5448958e46c09c387e96278a4
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10910
