Ticket #10091 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadBBY: new file format and reader

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.3
Component: SANS Keywords:
Cc: davidm@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

David writes:

We have decided to use TAR as a file container to hold the hdf and bin file. I have updated the bilby reader accordantly and attached to this email as well as a sample file. Please let me know how/where I can submit it.

This ticket is meant for pull request from David

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Cc davidm@… added

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

Updated unit test and usage example. re #10091

Changeset: 1952a068d9afa876d043b251e6e676a0507b8ae8

comment:4 Changed 6 years ago by Anders Markvardsen

Made loadbby to build on ubuntu. re #10091

here changed strongly typed enum to C++03 compatable enum, template variable was passed as temperatory object which (note the need for this was not fully understood), and removed various warnings

Changeset: b7a71d251142b57b663581950e79868dc2ade552

comment:5 Changed 6 years ago by Anders Markvardsen

Resolve merge conflict. re #10091

Merge branch 'master' of github.com:david-mannicke/mantid into feature/10091_new_bilby_format

Conflicts:

Code/Mantid/Framework/DataHandling/src/LoadBBY.cpp

Changeset: 00426ef9eb3761c213e998f9abed685c0f56bc60

comment:6 Changed 6 years ago by Anders Markvardsen

removal c++11 features not supported on mac. re #10091

Changeset: 261d4caa7f98cc3b119a74d7f3ed897edcee25e6

comment:7 Changed 6 years ago by Martyn Gigg

There are some cppcheck errors in LoadBBY: ​http://builds.mantidproject.org/job/cppcheck_develop/1488/cppcheckResult/

comment:8 Changed 6 years ago by Anders Markvardsen

Clear and suppress cppcheck warnings. re #10091

Changeset: c13d46d45dafb6c281492eb430b9d8ea32b977e0

comment:9 Changed 6 years ago by Martyn Gigg

There are also some compiler warnings on gcc: ​http://builds.mantidproject.org/job/develop_clean/label=rhel6-build/299/warnings19Result/

comment:10 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

check that unit test is passing and no warnings left

comment:11 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 6 years ago by Martyn Gigg

The output seems sensible and the filtering works as expected.

A new ticket will be generated to change the code style to be more Mantid conforming.

comment:13 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10091_new_bilby_format'

Full changeset: ​34407a6172b70230b78d9c9e051f9eeb446ea9af

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10933

Note: See TracTickets for help on using tickets.