Ticket #10099 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Plot to same graph

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Owen Arnold) (diff)

Request from user regarding the Reflectometry GUI:

The 'Plot' button generates a new plot each time, which is a bit annoying. Could we have a check if the plot already exists, in which case the plot should just update. Once can always invoke a new plot from the list of workspaces.

There is an option to do this now in Mantid. I believe the window option in plotSpectrum will do what we want.

Further to the above, the users also want to ensure that if they hit process again, and leave the exiting plots up, that they are automatically updated.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold

  • Description modified (diff)

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

Re-use plots when possible in Refl_Gui.py

Refs #10099.

Changeset: 3819c7ba1a076c83ae797a6d9e174b89a25f3ea1

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 6 years ago by Owen Arnold

Would prefer it if we start using double underscores to prefix any member variable names. This isn't the way that Max originally laid things out, but id rather like to keep any new member names mangled.

The one that is saw that was missing this was graph https://github.com/mantidproject/mantid/blob/3819c7ba1a076c83ae797a6d9e174b89a25f3ea1/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L51

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to verify
  • Resolution set to fixed

A new commit has been checkbuilt, but the ref'd ticket number was mistyped: https://github.com/mantidproject/mantid/commit/e7c32c7086946c18dbbd45e738633ae206e828c2

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:10 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10099_plot_to_same_graph'

Full changeset: 716580b1e013d64061b6cfe77e78869ac02bc264

comment:11 Changed 6 years ago by Owen Arnold

Seems to work nicely.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10941

Note: See TracTickets for help on using tickets.