Ticket #10103 (closed: fixed)
Scale column not applied
| Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
The Reflectometry Gui has a scale column in the table. The users say:
'Scale' only gets applied to the stitched data set. It should also work for the individual runs.
Contact Owen Arnold for help on this if required.
Change History
comment:4 Changed 6 years ago by Harry Jeffery
Correct misapplied scale column.
Not only was the scaling only being applied to stitched workspaces, but it was being applied twice, squaring the scaling factor. This commit resolves this issue by applying the scaling to all workspaces during the processing step.
Refs #10103.
Changeset: 338a4150705677f6619a9db87e046230945f4e43
comment:5 Changed 6 years ago by Harry Jeffery
Remove misleading refl_gui.py header.
The header is not accurate about the state and purpose of refl_gui.py. This commit removes the header to avoid confusion.
Refs #10103.
Changeset: 078298684b4170209c16849d36e295d1fd926b3e
comment:6 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
- Component changed from Framework to Reflectometry
Testing
- Verify scaling behaves correctly with values, 0.1, 1, 10, and any others you feel appropriate. These are easy to visually verify as the scale on the plots is logarithmic.
- Verify scaling is applied consistently to different runs on the same plot.
- Verify the final stitched workspace is correct when scaled and unscaled.
comment:7 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:8 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10103_scale_column_not_applied'
Full changeset: 8e0f7da3e762f4057b8747acbc5e0e3c1f085479
comment:9 Changed 6 years ago by Owen Arnold
Nicely done. Thanks for adding extra documentation. I didn't realise that the scaling was actually the inverse of the entered number until I started testing this.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10945
