Ticket #10113 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ReflectometryReductionAuto via ReflGUI cannot accept no ThetaIn

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.2.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Owen Arnold) (diff)

ReflectometryReductionOneAuto does not require ThetaIn. However, you can get the gui into a state where it demands it. Issue reported by Max Skoda on Inter.

To replicate:

  • Download run 13460 from INTER
  • Open the Refl Gui
  • Select 'Use RefectometryReductionOneAuto Algorithm' in the Options menu
  • In the table enter 13460 in the first run column, and nothing else!
  • Hit process.
  • Logs indicate failure because ThetaIn="" is not valid.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Keywords PatchCandidate added

comment:2 Changed 6 years ago by Peter Peterson

  • Keywords PatchCandidate removed
  • Milestone changed from Release 3.3 to Release 3.2.1

comment:3 Changed 6 years ago by Owen Arnold

  • Description modified (diff)

comment:4 Changed 6 years ago by Owen Arnold

refs #10113. Set angle to none.

Changeset: eefb823b45d1f659c2c70e9d939b5063d1554724

comment:5 Changed 6 years ago by Owen Arnold

refs #10113. Fix spelling.

Changeset: 4dc9c2e5a2833e145586fe72edce0ee5117c13cf

comment:6 Changed 6 years ago by Owen Arnold

Tester: The test instructions should now work. You should get two workspaces generated one in units of wavelength, one in units of momentum transfer.

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10113_thetain_problem'

Full changeset: ​b2cb7700203339c2d51436a6d418eea918df5725

comment:11 Changed 6 years ago by Owen Arnold

Cherry-pick fixes from feature/10113_thetain_problem into next

Changes:

refs #10113. Set angle to none. (cherry picked from commit eefb823b45d1f659c2c70e9d939b5063d1554724)

refs #10113. Fix spelling. (cherry picked from commit 4dc9c2e5a2833e145586fe72edce0ee5117c13cf)

Changeset: 6d9761c20381d12ce105142885a7295182b436e4

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10954

Note: See TracTickets for help on using tickets.