Ticket #10156 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadILL to support new IN4 File format

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Yannick, Raoul Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Ricardo Leal) (diff)

LoadILL needs to be changed to accommodate the new Nexus file format of IN4. Detector is now split in 2 data fields.

Also the IDF must be changed as in IN6. The detectors in the same column must have the same 2 theta.

Change History

comment:1 Changed 6 years ago by Ricardo Leal

  • Description modified (diff)

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Yannick Raoul

test

comment:4 Changed 6 years ago by Ricardo Leal

  • Cc Yannick, Raoul added; raoul@… removed

comment:5 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from assigned to inprogress

Re #10156 Rosace detector is loaded into the ws

Changeset: c93b8c6e286550a24a73b79afa6087b1c88b6fa6

comment:6 Changed 6 years ago by Ricardo Ferraz Leal

Re #10156 Tube detectors placed around a sphere.

Changeset: de0f5ebf04aedf701d6f3444ce6c60a34c3f1f6d

comment:7 Changed 6 years ago by Ricardo Ferraz Leal

Re #10156 Tube tilted following 2theta.

Changeset: a70efd5be19b04f0a889dd464457a2fffa017668

comment:8 Changed 6 years ago by Ricardo Ferraz Leal

Re #10156 Add IN4 test file and test

Changeset: d89d0a04466065398c90c2f0dfc45a703c012857

comment:10 Changed 6 years ago by Ricardo Ferraz Leal

Re #10156 IN4 test takes into account detector positions.

Changeset: d641b30d3ef1d994ff5fb15c76faba62fe82b2bd

comment:11 Changed 6 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

Note: there are also changes to merge in the systemtests repo.

To test:

LoadILL must Load ILL IN5 and IN4 files.

The system tests: 

ILLIN5Test.LoadILLIN5Test
ILLIN4Test.LoadILLIN4Test

Should take care of the necessary test cases.

To test there are IN4 and IN5 files in systemtests/Data/ILL/ILLIN?*

comment:12 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

The system tests are still broken on validating the IN6 definition: ​http://builds.mantidproject.org/job/develop_systemtests_rhel6/523/testReport/junit/SystemTests/ValidateInstrumentDefinitionFiles/ValidateInstrumentDefinitionFiles/

comment:13 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from reopened to inprogress

Re #10156 IN6 fix XML typos.

Changeset: 71b8aca1532f55b60be0efe07a98b4f568e95355

comment:14 Changed 6 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

Fixed the typo in the XML. System tests passed locally.

comment:15 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:16 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/master' into feature/10156_LoadILL_IN4_file_format

Full changeset: ​8d2a653ac0dce7126cc513a4915029a4d76f9623

comment:17 Changed 6 years ago by Anders Markvardsen

Merge remote-tracking branch 'origin/feature/10156_LoadILL_IN4_file_format'

Full changeset: ​f17a7940f7325301d973e53a854a77e0cc2808c4

comment:18 Changed 6 years ago by Anders Markvardsen

ILL systemtest and validateinstdefiles systemtest pass

comment:19 Changed 6 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/10156_LoadILL_IN4_file_format'

Full changeset: ​abebde24e940c5f25b00ee80768af718b6616eed

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10998

Note: See TracTickets for help on using tickets.