Ticket #10172 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadNexusMonitors loads monitor in wrong order (ISIS)

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

If there are more than 9 monitors they are sorted not by the monitor ID but by their group names in the nexus file: monitor_10 goes after monitor_1 and not after monitor_9.

LoadNexusMonitors should sort the monitors according to their monitor_number value if it present in the file.

Change History

comment:1 Changed 6 years ago by Roman Tolchenov

Re #10172. Sort monitor group names.

Changeset: 6f01f5723b40882cd8b759afd66dfed135c6e073

comment:2 Changed 6 years ago by Roman Tolchenov

Re #10172. Added a unit test.

Changeset: 836c97462a91943414aefd340f12fc200033ff95

comment:3 Changed 6 years ago by Roman Tolchenov

To test

  1. Load LARMOR00002102.nxs with LoadMonitors = true
  2. Show detectors of the monitors workspace.
  3. Check that the monitors are in the order of their IDs.

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:7 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10172_reorder_nexus_monitors'

Full changeset: ​a586a56643c126f56e8ce7f03e256c46defca2c2

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11014

Note: See TracTickets for help on using tickets.