Ticket #10189 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add centerpeak parameter in DiffSphere

Reported by: Jose Borreguero Owned by: Dan Nixon
Priority: minor Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #10279
Blocking: #9198 Tester: Raquel Alvarez

Description

DiffSphere fit function requires an extra parameter to allow shifts along the Energy axis.

Change History

comment:1 Changed 6 years ago by Jose Borreguero

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Jose Borreguero

  • Blocked By 10279 added

comment:3 Changed 6 years ago by Dan Nixon

  • Cc daniel.nixon@… added

comment:4 Changed 6 years ago by Jose Borreguero

  • Milestone changed from Release 3.3 to Release 3.4

comment:5 Changed 6 years ago by Dan Nixon

  • Owner changed from Jose Borreguero to Dan Nixon

comment:6 Changed 6 years ago by Dan Nixon

  • Cc daniel.nixon@… removed

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add Shift parameter to DiffSphere

Refs #10189

Changeset: 397705a846fa51ab5fbf07b7d50459ff1b1c98b8

comment:8 Changed 6 years ago by Dan Nixon

Also add Shift to DiffRotDiscreteCircle

Also had same issue, may as well fix here

Refs #10189

Changeset: c0ec79c8dec44b257b8e68621eac9043d0acfadf

comment:9 Changed 6 years ago by Dan Nixon

Update inelastic tests to run with shiift param

Refs #10189

Changeset: 30e5e3a9a449b352c465997a3a6636277cffc8b5

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #453.

comment:11 Changed 6 years ago by Dan Nixon

Set parameter alias correctly

Refs #10189

Changeset: 9b18ee758fffaecf0a8dd5b0e979888530fd5d64

comment:12 Changed 6 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:13 Changed 6 years ago by Raquel Alvarez

The fit is working much better now for both fitting functions.

comment:14 Changed 6 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #453 from mantidproject/10189_diffsphere_centre_shift

Add Shift parameter to DiffSphere and DiffRotDiscreteCircle

Full changeset: ​ca7daa3602737132efedd5a47112edf3209f989e

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11031

Note: See TracTickets for help on using tickets.