Ticket #10201 (closed: fixed)
Calculate Resolution Cleanup and Major Issues
| Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.3 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | #10198 | |
| Blocking: | #10210 | Tester: | Owen Arnold |
Description (last modified by Owen Arnold) (diff)
Enter these numbers ONLY into the first line of the reflectometry table:
run_number1 = 13460 run_number2 = 13462 transmission_run1 = 13463 (as comma separated for both tranmission run entries i.e. 13463,13464) transmission_run2 = 13464 (as comma separated for both tranmission run entries i.e. 13463,13464)
The Second angle never gets automatically populated since it is left blank. We should always populate this!. Same goes for the 3rd angle. Theta logs need to be extracted and populated per run.
The squish test is currently failing for this reason. http://builds.mantidproject.org/view/Develop%20Builds/job/develop_squishtest/
Also... as a follow on from the fix #10198
- Should handle single value logs, not just timeseriesproperties. Uses may for example use AddSampleLog to put a log value in place that is just a single value. https://github.com/mantidproject/mantid/blob/50e193e9078f605c0cac085238dea340a4222e9d/Code/Mantid/Framework/Algorithms/src/CalculateResolution.cpp#L85
- Should call strip on the theta value in column 1 to ensure that white space is not accidentally passed to float. https://github.com/mantidproject/mantid/blob/50e193e9078f605c0cac085238dea340a4222e9d/Code/Mantid/Framework/Algorithms/src/CalculateResolution.cpp#L85
Change History
comment:2 Changed 6 years ago by Owen Arnold
- Priority changed from major to critical
- Description modified (diff)
- Summary changed from Calculate Resolution Cleanup to Calculate Resolution Cleanup and Major Issues
comment:4 Changed 6 years ago by Harry Jeffery
Refs #10201. Autofill two theta in refl_gui.
This commit causes CalculateResolution to fetch a value for two theta and then place it into the table.
Also, the "run" workspace is a duplicate of a TOF workspace, so it is now named "_run" so that it can be cleaned up by quick.Cleanup().
Changeset: e53cc1fa5536fbbd6af3651a9006f7cb215c0752
comment:5 Changed 6 years ago by Harry Jeffery
Refs #10201. Support single value logs in CalcRes.
Changeset: 6e40287b1e876e0819a8bf4160382f28f2a2ebff
comment:6 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
- Strip does not need to be called on the columns being passed to CalculateResolution as they will have already been stripped: https://github.com/mantidproject/mantid/blob/50e193e9078f605c0cac085238dea340a4222e9d/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L161
comment:7 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:8 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:9 Changed 6 years ago by Harry Jeffery
- Status changed from reopened to inprogress
Refs #10201. Replace groupGet with getLogValue
Changeset: ce97557ebb7cf3c20e711a57aff626eb04c67487
comment:10 Changed 6 years ago by Harry Jeffery
Refs #10201. Use getLogValue to fetch theta
Changeset: 089c3d9cb8dc8474d65346dcd289a70b8be06130
comment:11 Changed 6 years ago by Harry Jeffery
Refs #10201. Remove orphan from refl_gui
Changeset: 672d7cc75a535ef98e192b2f0d10c5b4d6e998bd
comment:12 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10201_calc_res_improvements'
Full changeset: fd0d442e2519a8b7a40c26107f80308c3675562f
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11043
