Ticket #10203 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Make the log names for frequency and wave length more flexible in PDDetermineCharacterizations

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

In PDDetermineCharacterizations, the log names for frequency and wave length are hard coded. As VULCAN uses EPICS and the log names are different from those of POWGEN and NOMAD, it is better to allow user to specify the log names through algorithm properties.

Furthermore, SNSPowderReduction is the caller of PDDetermineCharacterizations in auto reduction. Thus the corresponding properties should be added to it too.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Added new properties. Refs #10203.

Changeset: 24eb6868a49b2f3431c75b16b65ee19fa2f131e6

comment:2 Changed 6 years ago by Wenduo Zhou

Resolved conflict. Refs #10203.

Changeset: 14218fc026283c4693316a087372498995655625

comment:3 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to fixed

For tester

  1. Check whether there is any unit test or system test, which is affected by the change in this ticket, is broken;
  1. Check the auto reduction script /SNS/VULCAN/shared/autoreduce/reduce_VULCAN.py. The new feature is applied in this script.

comment:5 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:6 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/10203_pddetermine_more_property'

Full changeset: ​1ecd8135e7a34c2777d5586e2d09cf78dc8d3f43

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11045

Note: See TracTickets for help on using tickets.