Error reporting in reflgui, and other theta related bug.

[Owen Arnold]

Take the file 13460, load it into mantid and remove the log Theta using DeleteLog. Then save it to a managed user directory (temporarily) as some other workspace name like INTER00001111.nxs. This will allow us to simulate not having a Theta log.

1) Open the refl_gui, make sure that ReflectometryReductionOneAuto is selected and enter 1111 into the table in the first row first column and hit process. You get the following error, which is not that helpful. We ought to tell people that entering dq/q manually will still work (because it does)

Error in execution of algorithm CalculateResolution:
Unknown property search object Theta
Traceback (most recent call last):
  File "/Users/spu92482/Documents/mantid_testing/mantid/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py", line 700, in _process
    dqq, two_theta = CalculateResolution(Workspace = loadedRun, TwoTheta = two_theta)
  File "/Users/spu92482/mantidbuild/bin/mantid/simpleapi.py", line 569, in algorithm_wrapper
    algm.execute()
RuntimeError: Unknown property search object Theta

2)

Do exactly the same as above, start with a fresh instance of the gui, and unselect using ReflectometryReductionOneAuto. You get the following error: Is there a way to avoid this? I think this might just be down to a bad attempt at a type conversion?

  File "/Users/spu92482/Documents/mantid_testing/mantid/Code/Mantid/scripts/Reflectometry/isis_reflectometry/quick.py", line 210, in quick_explicit
    theta = float(theta)
TypeError: float() argument must be a string or a number

If we cannot solve 2 above easily. We ought to change the default settings so that ReflectometryReductionOneAuto becomes the default choice for processing.

[Harry Jeffery]

Refs #10210 Tweak error reporting in refl gui.

Changeset: a003af15c4eef1636b0a42757498d2c125b1ae59

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/10210_tweak_error_reporting_in_reflgui'

Full changeset: ​4aed4eabfab7b8c801381ebe9798d14a77514238

[Stuart Campbell]

This ticket has been transferred to github issue ​11052