Ticket #10230 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add more information to Mantid Matrix Headers

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.3
Component: GUI Keywords: CORE
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Nick Draper) (diff)

The headers (horizontal and vertical) currently only display the index value.

Could these also display the spectrum number, and the bin centre value respectively?

Change History

comment:1 Changed 6 years ago by Nick Draper

The headers (horizontal and vertical) currently only display the index value.

Could these also display the spectrum number, and the bin centre value respectively?

comment:2 Changed 6 years ago by Nick Draper

re #10230 supports all axes types

Changeset: c2e32e8ed1ee7fc7e9a1a8936a521d667035d1bf

comment:3 Changed 6 years ago by Nick Draper

CORE CHANGES

  1. Added new method to MatrixWorkspace isCommonBins()
    1. returns if the workspace has common X bins
    2. Uses the validation previously from CommonBinsValidator
    3. Value is cached in m_isCommonBinsFlag
    4. cache is invalidated if workspace X values are accessed with write possibility
  2. Changed CommonBinsValidator to call isCommonBins()
Last edited 6 years ago by Nick Draper (previous) (diff)

comment:4 Changed 6 years ago by Nick Draper

  • Keywords CORE added
  • Status changed from new to assigned
  • Description modified (diff)

comment:5 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress
  • Description modified (diff)

Core added after the fact as this ticket required minor changes to MatrixWorkspace and CommonBinsValidator. The changers were discussed before implementation with Martyn Gigg.

To Test

This ticket contains CORE changes and needs to the tested by a senior developer.

  1. Start Mantid, Load some normal TOF data
  2. Bring up the Matrix view, the headers to either side now contain more information. You can get tooltips with a fuller explanation.
  3. Before you comment that it would be nice to label things on the "empty" top left corner button, this is far from an easy thing to do, the only way is to inherit from the listview control and override the paint method of that button.
  4. Try changing between the X, Y ane E views, and scrolling around. I don't display the extra data on the TOF axis of the X view as the bin centre values alongside bin edge values would be confusing.
  5. Change units with ConvertUnits.
  6. If you did not rebin then you will get "varies" for ragged workspaces
  7. If you rebin the extra data should come back and be correct for the new unit.
  8. Try other algorithms that will change the axes types, both for the horizontal and vertical axes. I used ConvertAxesToRealSpace to get a Numeric Axes on both sides. Fit should give you a label axis vertically.
  9. do the above both for a new workspace and replacing the workspace with the matrix still visible to check we have no problems with updating for changes.

comment:6 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Nick Draper

Revert "re #10230 supports all axes types"

This reverts commit c2e32e8ed1ee7fc7e9a1a8936a521d667035d1bf.

Changeset: a884f0fa01b241dc42f1b5d135629666613867f3

comment:8 Changed 6 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:9 Changed 6 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #10230 fix validation error

Changeset: 1d455ec385ccd9ac258a9b1080fcef25900fad8a

comment:10 Changed 6 years ago by Nick Draper

re #10230 fix validation error

Changeset: d176de98dffb134d1f96c36a82e24a81e32b2ca7

comment:11 Changed 6 years ago by Nick Draper

Revert "re #10230 fix validation error"

This reverts commit d176de98dffb134d1f96c36a82e24a81e32b2ca7.

Changeset: 8430d1ed539deaa6865b2534fc1644e82497c9eb

comment:12 Changed 6 years ago by Nick Draper

Revert "re #10230 fix validation error"

This reverts commit 1d455ec385ccd9ac258a9b1080fcef25900fad8a.

Changeset: 4ba929fc2bbd12ae28fcd557475784304234d745

comment:13 Changed 6 years ago by Nick Draper

Revert "Revert "re #10230 fix validation error""

This reverts commit 4ba929fc2bbd12ae28fcd557475784304234d745.

Changeset: e26ead4bc6ba4a2b20629e0ac76fa03bd3113630

comment:14 Changed 6 years ago by Nick Draper

Revert "Revert "re #10230 fix validation error""

This reverts commit 8430d1ed539deaa6865b2534fc1644e82497c9eb.

Changeset: b7381922a1f8ba5a81caedd9bb3f938e66d84506

comment:15 Changed 6 years ago by Nick Draper

re #10230 revert isHistogramData changes, improve numericAxis handling

Changeset: 2bb8cb4102dd97cef379196d716fd7f242117d78

Last edited 6 years ago by Nick Draper (previous) (diff)

comment:16 Changed 6 years ago by Martyn Gigg

There are some gcc compiler warnings coming from MantidMatrix: http://builds.mantidproject.org/job/develop_clean/345/warnings19Result/

comment:17 Changed 6 years ago by Nick Draper

re #10230 compiler warnings

Changeset: 9aa2eb4ee3c1863e6d89efe266162742c1c1c4ef

comment:18 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test and core sections are ealier in the comment section

comment:19 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:20 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Generally I think this is a good improvement to the matrix.

A couple of comments while testing:

  • I loaded a WISH dataset and convert to dSpacing. The first few spectra are monitors and as a result their X values are inf and this is then displayed in the second row of the header. I presume in this case that the isCommonBins check is failing?
  • Related to this: I'm not too sure about just the single word 'varies' when the bins don't match. When I first looked at it my immediate thought was "what varies in what direction"? Would something like "bins vary" be better?

Other than that things worked well.

Last edited 6 years ago by Martyn Gigg (previous) (diff)

comment:21 Changed 6 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #10230 fix varies message and deficiency in common bins check

Changeset: 001282824d6e573e37e88e0301c35ef22a8b24eb

comment:22 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:23 Changed 6 years ago by Nick Draper

re #10230 cppcheck warning

Changeset: 6366aed4f2b01a8dbbfad901e103d9f7309be724

comment:24 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:25 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10230_more_info_on_mantid_matrix'

Full changeset: 5418eca4ead93b8ad437d427b634683a2d900aa0

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11072

Note: See TracTickets for help on using tickets.