Ticket #10233 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Refl_gui should default to use the Reflectometry algorithms, not the scripts

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

This is part of our migration away from the scripts. We will (for now) keep the option to go-back, but we are going to force users across to the new algorithms, even if their existing settings suggest otherwise.

To do this we need introduce a one-time q-settings key to determine if the migration has happened yet, or not, so that we can allow the users to still move around after the one-time change. This would also allow us to keep the same keys, so that users can go back to older versions of mantid, and the same keys will still exist.

The current key is called:

[Mantid]
ISISReflGui
AlgUse=true

Change History

comment:1 Changed 6 years ago by Owen Arnold

refs #10233. Add new setting and switch.

Changeset: 1e4b53bf75ad6ddcf11852a86eaf4394ca67df6d

comment:2 Changed 6 years ago by Owen Arnold

To test this:

  1. Open up the Refl Gui in the user interfaces, go to the options menu, you SHOULD see that Use ReflectometryReductionOneAuto is checked.
  2. In the table of the gui, first cell, first row, enter 13460. Don't enter anything else.
  3. In MantidPlot, Open your mantid log results window and change the setting to 'Notification'
  4. Back on the refl gui, Hit 'process' and there should be a some IvsQ and IvsLam workspace generated (run number included in name)
  5. Look at the mantid plot log window, and it should record the fact that it has run 'ReflectometryReductionOneAuto'
  6. Open the refl gui menu options again and turn 'Use ReflectometryReductionOneAuto' OFF.
  7. Close down mantidplot and restart, open the reflectometry gui options menu again, it should have remembered that you turned the last option to OFF.
  8. Perform the same steps as above to reduce a run. Check the logs, this time it should not report the use of ReflectometryReductionOneAuto, you'll see a whole load of calls to other lower level algorithms instead, such as Crop and Rebin. You should get the same output workspaces generated as before.

comment:3 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10233_defaults'

Full changeset: 2a1b552050d5ef532fc13bf1d72343d6bfc9f9cd

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10233 Remove FakeView from MockObjects

Changeset: d4de26e91df9bd2356c1e7e5a9e48701d6be2345

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11075

Note: See TracTickets for help on using tickets.