Ticket #10236 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

QMainWindow MDISubWindow issue

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.3
Component: GUI Keywords: CORE
Cc: Blocked By:
Blocking: #10237 Tester: Owen Arnold

Description

Solve subwindow issue.

Menus are not properly displayed on Custom interfaces and are not shown at all on OSX. This is a problem for the new reflectometry gui you are working on.

Custom Interfaces inherit from UserSubWindow, which inherit from QWidget. We believe they should inherit from QMainWindow.

You'll need to work with Martyn Gigg on this issue as it will affect a lot of functionality, and should be solved in general, not just for the ReflectmetryGui.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Blocking 10237 added

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned
  • Keywords CORE added

This needs to be tested carefully across a wide range of interfaces and OS's. Therefore CORE added.

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

Refs #10236 Inherit QMainWindow in MdiSubWindow

Changeset: e1cbfd8cbe93b30bb8f6d1c43a84d7d4ffec401f

comment:4 Changed 6 years ago by Harry Jeffery

Refs #10236 Update ReflMainWidget.ui

Changeset: 6eba914579828852d7dbdb242d11b832f92f2dc8

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10236 Update remaining ui files

Changeset: 28204b7e9c030890b3329a60ac927153afb45141

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

As this is a core change it needs to be tested on Windows, OS X and Linux.

  • Play with the custom interfaces
    • Verify they are not obviously broken
    • Play with one you are familiar with, verify that it is working as normal

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 6 years ago by Owen Arnold

The interfaces that i've checked seem to be working as expected. I'll add an extra note to the unscripted manual testing for testers to check All User Interfaces http://www.mantidproject.org/Unscripted_Manual_Testing

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10236_customint_inherit_qmainwindow'

Full changeset: ​fb48c2a9a1860f115328fb43a83109b96b0efbaa

comment:10 Changed 6 years ago by Owen Arnold

Merge remote-tracking branch 'origin/feature/10236_customint_inherit_qmainwindow'

Full changeset: ​fb48c2a9a1860f115328fb43a83109b96b0efbaa

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11078

Note: See TracTickets for help on using tickets.