Put menu options on new ReflGui

[Owen Arnold]

Solving the previous issues (see blockers) will mean we can put menus onto the gui.

Remember that in passive MVP, we do not want the views to know anything about processing logic. They must not therefore perform conditional branching based on menu selections, and they should not even launch menus themselves. One way around this would be to create a new MVP group for say the ReflGuiOptions dialog. This could be kicked off by the main presenter.

[Harry Jeffery]

(In #10347) Option for rounding/truncating requires #10237 to be in place first.

[Harry Jeffery]

Refs #10237 Add empty Options dialog

The user is now able to open an empty options dialog. The dialog uses the QtReflMainView as its parent and gets a copy of the shared pointer to the presenter.

The ui of the new dialog is defined by ReflOptionsDialog.ui.

Changeset: 2f1b158caa2767501002e7c618ef583579ca28e4

[Harry Jeffery]

Refs #10237 Add options to ReflMainViewPresenter

Changeset: 9e3ecceacd6a9736af65a846d580edbfc4c99126

[Harry Jeffery]

Refs #10237 Use options in Refl UI

To demonstrate the basic functionality a "WarnProcessAll" options has been added. This allows the user to decide whether or not they wish to be warned when they try to process all the rows (by not selecting any before hitting process).

Changeset: 3cd1e03308093d4868eef31f86fbf7d63d259a4a

[Harry Jeffery]

Refs #10237 Expedite options dialog deallocation

Changeset: 3af0c90d1dc0fca4df5bbb1e43ecebda70823de8

[Harry Jeffery]

Refs #10237 Store options as QVariants

This way we don't need to handle type conversion ourselves. We can let QVariant take care of that for us.

Changeset: f75a370139c3defebd42ef01c4290cff66b0e26a

[Harry Jeffery]

Refs #10237 Persist options using QSettings

Options are saved in the group: Mantid/CustomInterfaces/ISISReflectometry

Changeset: 57e83ef61e6be48bef9725b0a5b76ab4929e57aa

[Harry Jeffery]

Testing

This ticket provides a dialog for configuring options/settings for the ISIS Reflectometry UI. A simple option to enable/disable the "Are you sure you want to process all rows?" prompt has been added to it for the purposes of testing.

• Verify that the dialog behaves intuitively
• Verify that the settings persist between runs of the application
• Verify that the "Warn when processing all rows" setting works as expected
• Review changes
• Verify no unit tests have been broken

Branch: ​https://github.com/mantidproject/mantid/compare/feature/10237_refl_ui_options_menu

[Federico M Pouzols]

This looks all fine. The unit tests pass, and the simple options dialog behaves well. The new code looks well structured and it comes with good documentation. More specifically about the dialog:

• the "warn" option persists between different runs
• the warning is shown when it should. A detail: do you also want to show this warning when there's very few or just one row?
• the dialog itself behaves as I would expect, even though the "new refl" is still growing I'd guess. I was missing for example a quit/exit entry.

[Federico Montesino Pouzols]

Merge remote-tracking branch 'origin/feature/10237_refl_ui_options_menu'

Full changeset: ​644714f30ffb0612ddd8dca6737907316d4a6cf6

[Harry Jeffery]

Refs #10237 Include QVariant rather than declare

Changeset: b7309429cef08e03963cab525ff0a3f240fb7250

[Martyn Gigg]

Merge branch 'feature/10237_refl_ui_options_menu'

Full changeset: ​71f4ed4bcbd6059301f1dc7f6d040b2696e2a4a7

[Stuart Campbell]

This ticket has been transferred to github issue ​11079