Add plot buttons to new ReflGui

[Owen Arnold]

Should be similar to behaviour of old gui.

[Harry Jeffery]

Blocked by documentation, as this would have to update the new documentation before it could be merged.

[Harry Jeffery]

Refs #10238 Remove unneeded virtual keywords

These won't be inherted. They don't need to be virtual.

Changeset: 128ec77e01c7097c355cd77de454bda7dcc1fcfd

[Harry Jeffery]

Refs #10238 Add plotWorkspaces method to QtReflMainView

Changeset: 899a6329b60e7070c6864d80fb8cc28d51d597c9

[Harry Jeffery]

Refs #10238 Add plotting actions to Refl UI

Changeset: 2f54216cb0f600859b963c946f9ce458f6ae4ac6

[Harry Jeffery]

Refs #10238 Implement plotting in Refl UI

Changeset: 9771db7e61322a68c64e683d8f64cd74f281001e

[Harry Jeffery]

Refs #10238 Support multi-run rows for group plotting

Changeset: 67655d1970b77cedfffe48db8dca97b93dad7625

[Harry Jeffery]

Refs #10238 Document new plot actions

Changeset: a737b066e19f479b43ae77bd9145ae89b858f460

[Harry Jeffery]

Refs #10238 Don't attempt to plot non-existant workspaces

Changeset: d50604ea3d93eee1ae0f7fa6ee4f285a85af468d

[Harry Jeffery]

Testing

• There should be two new plot buttons in the new Refl UI
  • Verify the documentation acknowledges and explains their existence and effect sufficiently
• Verify unit tests are passing
• Play with the plot buttons after processing some data
  • The plot rows button should generate one curve per row selected (that has been processed)
  • The plot groups button should generate one curve per group selected (that has been processed)

[Federico M Pouzols]

This seems to be working well, except for one detail:

• The "plot groups" button doesn't work when the group has more than one run.

I did the following. With INTER as instrument, I add one row: run 7709, angle: 1. Hit process, it works, and I can happily use "plot row" and "plot group". Add a second row: run 13463, angle 0.5. Hit process. Works well and I can plot it as a row and as a group. The two rows have groups 0 and 1. If I change the first row group to 1, or if I change the second row group to 0, then "plot group" doesn't do anything. Using the "group selected" button doesn't seem to help. With more rows the behavior is similar: when you put more than one row in a group, then the "plot group" button stops working for those rows. The menu actions behave exactly the same as the buttons.

I can get multi-line plots with "plot rows" on multi-selections, but I cannot get multi-line plots with "plot group"

Everything else seems fine:

• The buttons are well explained in the doc.
• The plot selected rows works
• It's well documented, the GUI elements come with tooltip and what's-this strings.
• Unit tests pass.

So I'd guess this is just a minor issue somewhere in the code. Or I might be misunderstanding something. In such case the doc might need clarification.

[Harry Jeffery]

Refs #10238 Warn when plotting unprocessed rows

Changeset: 34bff70ca9204b1b7e4635badf410ef9cb65f32f

[Harry Jeffery]

Refs #10238 Test plotting warnings

Changeset: a8c85dad72b323251adbc6bf8f26e07485eb6809

[Harry Jeffery]

In that case, the reason plotting was not occurring was because the group had not been processed, so there wasn't a workspace to plot. The interface now shows a warning when this is the case, and explains how to the user how to fix it.

[Federico M Pouzols]

Perfect. Now even lousy users like me will be guided to do things properly. It also comes with new mock GUI tests which pass.

[Federico Montesino Pouzols]

Merge remote-tracking branch 'origin/feature/10238_refl_ui_plot_actions'

Full changeset: ​e2584d4690d125e16d15dee447428a046a5f0643

[Stuart Campbell]

This ticket has been transferred to github issue ​11080