Ticket #10245 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

replay history on windows broken

Reported by: Anders Markvardsen Owned by: Nick Draper
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

To reproduce on windows do

  1. Put some data in a folder with a name like 'nnn'. E.g. the CNCS_7860_event.nxs data
  1. Get history and copy to clipboard which when passed gives:

Load(Filename='C:\nnn\CNCS_7860_event.nxs', OutputWorkspace='CNCS_7860_event', LoaderName='LoadEventNexus', LoaderVersion=1)

which will not run on window. it is missing the 'r'. Hence it should have been:

Load(Filename=r'C:\nnn\CNCS_7860_event.nxs', OutputWorkspace='CNCS_7860_event', LoaderName='LoadEventNexus', LoaderVersion=1)

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Summary changed from reply history on windows broken to replay history on windows broken

comment:2 Changed 6 years ago by Nick Draper

  • Owner set to Nick Draper
  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #10245 add r to property strings containing backslashes

Changeset: 90fb69ba46e056c48fb51dc6991b61b510bff842

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

  1. use Windows!
  2. Load a file (the path will include a backslash). If you want to be really cruel load a file for a directory starting with a lower case n.
  3. Extract the histoy from the workspace
  4. run it (successfully) - also any text properties containing \ should be prefixed with r
  5. Start RecordPythonScript
  6. Load a file
  7. Cancel RecordPythonScript (this is when the file is written)
  8. Check the file, any \ strings should be prefixed with r and run successfully.

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:6 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10245_python_history_file_paths'

Full changeset: e7d77f95e38ee4514a272568154bf21250d74435

comment:7 Changed 6 years ago by Anders Markvardsen

tested with file in nnn directory

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11087

Note: See TracTickets for help on using tickets.