Ticket #10250 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Move Stitch1DMany algorithm to C++

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10223 Tester: Anders Markvardsen

Description

Stitch1DMany is being used by the new Reflectometry UI and as such, is run from one of the new UI's unit tests. However, as a Python algorithm Stitch1D cannot easily be run from within a C++ unit test.

By moving the algorithm to C++ it can be executed from within the Reflectometry UI unit tests without issue.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

Refs #10250 Remove python Stitch1DMany

Changeset: 37e602f80433f6e726111df22571475d955e6509

comment:3 Changed 6 years ago by Harry Jeffery

Refs #10250 Add C++ Stitch1DMany stub

Changeset: 8c2e005d27964144b50b4f0398e7bf4c63396cc6

comment:4 Changed 6 years ago by Harry Jeffery

Refs #10250 Add basic input validation

Changeset: ba0e0bda999ad137dca19688be5184bb5ec1182c

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10250 Add basic stitching implementation

Changeset: 5e184bf83a36799428c84e9816ff3d5df3f60ac3

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10250 Re-add Stitch1DMany python test

Changeset: a2c9bcc65543f73f78cea41c22a3d1fbcd247d4a

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10250 Add support for processing groups

Changeset: 7060f9b405e731ced58674f280ae5e12cc45f691

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

As this is merely a direct move of the algorithm from Python to C++ there should be no functional differences before and after this ticket. To help ensure this, the C++ version is using the exact same unit test as the original Python version.

  • Verify unit tests are passing
  • Sanity-check code. Compare Python implementation to C++ implementation.
  • Verify that the develop system tests are passing.
    • Be sure that the the most recent develop system tests include these changes.
  • Verify the usage examples in the documentation are still working.

Branch: ​https://github.com/mantidproject/mantid/compare/feature/10250_move_stitch1dmany_to_cpp

comment:9 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:10 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10250_move_stitch1dmany_to_cpp'

Full changeset: ​03921fe379259eabd446595d352c7f2a5a718028

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11092

Note: See TracTickets for help on using tickets.