Ticket #10256 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

WienerSmooth algorithm should smooth whole workspace by default

Reported by: Martyn Gigg Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description (last modified by Martyn Gigg) (diff)

WienerSmooth was implemented in #934. It currently only processes a single spectrum but it would be more useful if the default was to process all spectra of a workspace but have the option to limit it using a property.

As this is still a new algorithm we have more flexibiliy to change the types and names of the properties.

The documentation could use a little extra work as well. It would be good to at least try and describe the overall process of the smoothing and linking to a reference if possible.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #10256. Smooth all or selection of spectra.

Changeset: 8d5a3726786b5af6595177cc1e955787c31c79d3

comment:4 Changed 6 years ago by Roman Tolchenov

Re #10256. Updated the unit test.

Changeset: 3b15d0033524261f9c41c59e31b9cf66018661c7

comment:5 Changed 6 years ago by Roman Tolchenov

Re #10256. Copy the axis.

Changeset: 0aa4b2dc7923ef098d40e92f017421a8fa2b88cf

comment:6 Changed 6 years ago by Roman Tolchenov

Re #10256. Multispectra unit tests.

Changeset: 1352c604cdb2a7aea7bdb2c0910e59d3d45f5d19

comment:7 Changed 6 years ago by Roman Tolchenov

Re #10256. Fix compiler warning.

Changeset: e9bc5f9d7394b1ed966a391fd4960d10d4d30cfb

comment:8 Changed 6 years ago by Roman Tolchenov

Re #10256. More documentation.

Changeset: 4e213df2fc6478b321ed2265f73c53b368060dc8

comment:9 Changed 6 years ago by Roman Tolchenov

Re #10256. Added progress reporting.

Changeset: 9411182611d00c6a1410cf6938e0cf7921782146

comment:10 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester

Run the algorithm on MUSR00022725.nxs from autotest data.

comment:11 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:12 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Important note: as the list of new/modified algorithms was generated some days ago, please remember to remind Martyn to add this algorithm in the list for the release notes (modified algorithms).

All looks fine:

  • Running it on MUSR data files produces sensible results, and it's not slow at all
  • you can select a subset of spectra from the original workspace(s)
  • code changes look good
  • the unit test has been expanded, and it passes
  • the documentation reads well, and comes with references and example screenshots

comment:13 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/feature/10256_wiener_smooth_all_workspace'

Full changeset: ​0d5fe6c2c8f5fec09784956b34369a23effc8666

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11098

Note: See TracTickets for help on using tickets.