C2E: Instrument configuration should be common to all tabs

[Dan Nixon]

Something noted by Vicky and Spencer:

Currently the instrument, analyser and reflection are selected on the Energy Transfer tab, but the values they are set to are used on multiple tabs (at least Calibration).

A better solution would be to move the instrument config out of the tab and place it in a group box below the tabs but above the bottom buttons.

[Dan Nixon]

Move instrument options below tabs

Refs #10266

Changeset: e7c926151cc91ba69e60bbcafd0d5e7743220835

[Dan Nixon]

Add spacing on Energy Transfer

Refs #10266

Changeset: 794936a1633cead118385875bb98f45a886d84a1

[Dan Nixon]

Its more logical to have instrument selection at the top

Refs #10266

Changeset: 4252c594a8fbf6248d09c3a6b81f0db2d18c8cda

[Dan Nixon]

Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs

Refs #10266

Changeset: db5dd6a396856e9f9d88c671fb8348fe2cb33ad0

[Dan Nixon]

Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs

Refs #10266

Changeset: 92f6cf799c0d2d9ee0152a2eb10e8564ec92c158

[Dan Nixon]

Add instrument changed signal to IDR & tab

Refs #10266

Changeset: c36e2e06147711b1d8af8d56adfbe6865898e674

[Dan Nixon]

Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp

Refs #10266

Changeset: 25485a5d65e0390f1936c1cad14b45da60fb0c6b

[Dan Nixon]

Moved inst loading and UI code to IndirectDataReduction

Refs #10266

Changeset: 22ad3e6deb0a2db2ddbde8886a995109bb44bba3

[Dan Nixon]

Re add trans, symm and moments

They do not care about the instrument

Refs #10266

Changeset: 53fa6287f28c8f63027909203f2a566d52223a8f

[Dan Nixon]

Re-add SQw, get efixed using getInstrumentDetails()

Refs #10266

Changeset: a5a92d1b162897165f90fa251fd7e785e47274c7

[Dan Nixon]

Re-add diagnostics tab

Refs #10266

Changeset: 3cb0d715d45fd2d80e5287517ee3efdd6434c43b

[Dan Nixon]

Re-add calibration, use detector ranges from IPF

Refs #10266

Changeset: 4d0af24b18fbe95d1891736ad4d3024e8c7c0d30

[Dan Nixon]

Re-add convert to energy

Refs #10266

Changeset: 28106812d3c39388f189f9aaec39fe5c28ba585e

[Dan Nixon]

Auto update instrument details in Calib and Diag

Refs #10266

Changeset: 86fcd61383f6e7868432047d75434cb63be98ddf

[Dan Nixon]

Removed some duplicated code

Refs #10266

Changeset: a29711491312489f3f5ed29d7167f26c74f1c85c

[Dan Nixon]

Fix TOSCA inst loading

Refs #10266

Changeset: b0d950e893dd4ce684b817616b8a835ef6459a79

[Dan Nixon]

Merge branch 'feature/10266_idr_instrument_common_to_all_tabs' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp

Refs #10266

Changeset: ef2e4cb3da07529fab3f7b5f293556405f51ee38

[Dan Nixon]

To test:

• Open Indirect > Data Reduction
• Change the instrument, analyser and reflection, ensure that only valid combinations are given (see end of comment)
• On energy transfer, calibration and diagnostics change the instrument/analyser and verify the spectra ranges change.
• On calibration and diagnostics ensure the peak and background ranges change.
• On energy transfer ensure the efixed value changes (note, TOSCA should be 0 (or at least the IPF says it should be))

Valid instrument combinations:

• IRIS
  • graphite
    • 002
    • 004
  • mica
    • 002
    • 004
    • 006
  • fmica
    • 002
    • 006
• OSIRIS
  • graphite
    • 002
    • 004
• TOSCA
  • graphite
    • 002

[Dan Nixon]

Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs

Refs #10266

Full changeset: ​db5dd6a396856e9f9d88c671fb8348fe2cb33ad0

[Dan Nixon]

Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs

Refs #10266

Full changeset: ​92f6cf799c0d2d9ee0152a2eb10e8564ec92c158

[Dan Nixon]

Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp

Refs #10266

Full changeset: ​25485a5d65e0390f1936c1cad14b45da60fb0c6b

[Harry Jeffery]

Merge remote-tracking branch 'origin/feature/10266_idr_instrument_common_to_all_tabs'

Full changeset: ​7c6863bf4abd1399a1a2c115fbfeb91846f877ac

[Dan Nixon]

Merge branch 'feature/10266_idr_instrument_common_to_all_tabs' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp

Refs #10266

Changeset: ef2e4cb3da07529fab3f7b5f293556405f51ee38

[Stuart Campbell]

This ticket has been transferred to github issue ​11108