Ticket #10275 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Stitch1DMany does not preserve history

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

Stitch1DMany does not preserve the history of its input workspaces. The history should be kept.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

Refs #10275 Make Stitch1DMany preserve history

Changeset: c78dd1a301d51797be0b9a1eb921974ce3d91af9

comment:2 Changed 6 years ago by Harry Jeffery

Refs #10275 Fix bug in history preservation

Stitch1DMany would sometimes appear at the start of the history log.

Changeset: 708bdece3a5d2bab3bb281f1488143ac6aa13d88

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to verify
  • Resolution set to fixed

Testing

  • Run the given python script
  • Verify the history of stitched_wav is correct 
trans1 = Load('INTER00013463')
trans2 = Load('INTER00013464')

trans1_wav = CreateTransmissionWorkspaceAuto(trans1)
trans2_wav = CreateTransmissionWorkspaceAuto(trans2)

workspaces = trans1_wav.name() + ',' + trans2_wav.name()
stitched_wav, y = Stitch1DMany(workspaces, params='1, 0.05, 17', UseManualScaleFactor=True, ManualScaleFactor=0.85)

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10275_stitch1dmany_preserve_history'

Full changeset: ​c25342988b7db8e68a5365a97aa8a098fda2977d

comment:7 Changed 6 years ago by Dan Nixon

Merge remote-tracking branch 'origin/feature/10275_stitch1dmany_preserve_history'

Full changeset: ​c25342988b7db8e68a5365a97aa8a098fda2977d

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11117

Note: See TracTickets for help on using tickets.