Ticket #10288 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

reduce tolerance of LOQReductionGUI systemtest

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: minor Milestone: Release 3.3
Component: SANS Keywords:
Cc: borreguerojm@… Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Anders Markvardsen) (diff)

With reference to #10287 where the tolerance was increased.

Check with instrument scientists before reducing tolerance of this systemtest.

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Peter Parker to Anders Markvardsen
  • Milestone changed from Backlog to Release 3.3

comment:3 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

Fix TabulatedFunction Shift parameter. re #10288

Update code doc to reflect change Updating fitting table output

Changeset: 431c55684b1e8a5f0c447107372ec5730b89ae88

comment:4 Changed 6 years ago by Anders Markvardsen

LOQReductionGUI back in operation. re #10288

Changeset: ce6accd6e89a098589c47c272d79075bd28c14db

comment:5 Changed 6 years ago by Anders Markvardsen

  • Description modified (diff)

This work has been discussed with Richard, importantly in fitting the front and read data he would have been the wrong physics to have utilise added TabulatedFunction shift parameter.

In commit above TabulatedFunction shift is therefore fixed to 0.0.

comment:6 Changed 6 years ago by Anders Markvardsen

  • Cc borreguerojm@… added
  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

  1. check that tolerance in LOQReductionGUI have to reduced to 1e-5

2 and that this and all ISIS SANS systemtests are passing

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10288_sans_tablefunction_fitting'

Full changeset: ​11f84df22ba334036554eefa00da2fb2883e99f9

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11130

Note: See TracTickets for help on using tickets.