Ticket #10324 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Up/Down arrows on Spectrum View should move cursor by one spectrum

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: #10441 Tester: Harry Jeffery

Description

When using the arrow keys to move the cursor on the spectrum viewer it takes two key presses to increment or decrement the spectum number, instinctively it should only take one.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Owner set to Dan Nixon
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Convert Y axis to value for increment

refs #10324

Changeset: db50fb13f4e5d90908f5985bc679c4cb16066e32

comment:3 Changed 6 years ago by Dan Nixon

Fix some compiler warnings

Refs #10324

Changeset: a25fbab79a4ad7e8bfe6ffd8906a0980eaa20ce3

comment:4 Changed 6 years ago by Dan Nixon

Moving by 1 spectra working, needs refactoring

Refs #10324

Changeset: b4d795fd68d7e48d290aea997581ffda5b07bace

comment:5 Changed 6 years ago by Dan Nixon

To test:

  • For each of:
    • A workspace with one spectra (e.g. irs26173_graphite002_res.nxs)
    • A workspace with a few spectra (e.g. irs26176_graphite002_QLr_Workspace.nxs)
    • A workspace with a reasonable amount of spectra (e.g. IRS26173.RAW)
    • A workspace with many spectra (e.g. OSIRIS00106551.raw)
    • A workspace with an insane number of spectra (CreateSampleWorkspace(OutputWorkspace='sample', Function='Multiple Peaks', NumBanks=100, BankPixelWidth=50, Random=True))
  • Load the workspace and open the Spectrum Viewer
  • Enable mouse controls by clicking on the contour plot
  • Use up and down arrow keys, notice the spectrum moves by one only
  • Verify this still works after resizing the spectrum viewer window
  • Also notice it is possible to select every spectra using the mouse (previously around only 50% of spectra were ever shown in the spectrum viewer)
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:6 Changed 6 years ago by Dan Nixon

  • Blocking 10441 added

comment:7 Changed 6 years ago by Dan Nixon

Update scroll bars on resize

Refs #10324

Changeset: 5f23e4b0145b84ada9d98db853060165ff763769

comment:8 Changed 6 years ago by Dan Nixon

Correct compiler warning

Refs #10324

Changeset: e63c5a3b9ba7f03d44df28452fcb9fd0e1d06689

comment:9 Changed 6 years ago by Dan Nixon

Correct scroll bar movement

Refs #10324

Changeset: 4f48f6d74c72f0142e4a3566054551226b3558d5

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Dan Nixon

Resize scroll bars when image split is moved

Refs #10324

Changeset: 4cf175b7df7c136984277c09eecacab386fd7b4d

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:13 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Was able to use arrow keys to navigate by less than one spectra at a time on IRS26173.raw

comment:14 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Fix buggy spectra moving

Refs #10324

Changeset: e45704d8a36ea152301e7c583b3f590229a6ba22

comment:15 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:16 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying

comment:17 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10324_spectrum_view_keys_move_by_one_spectrum'

Full changeset: bc2aee8b4d3abc941de1f558795741c00da85f7f

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11166

Note: See TracTickets for help on using tickets.