Ticket #10331 (closed: fixed)
install_git_macros.bat should be able to find Git
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Tools | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description (last modified by Dan Nixon) (diff)
To test (Windows only):
- Remove the Mantid macros from your Git installation
- Run install_git_macros.bat
- Try to run a Mantid Git macro
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Added code to find the Git install path
Based on code found here: http://stackoverflow.com/questions/8507368/finding-the-path-where-git-is-installed-on-a-windows-system
Refs #10331
Changeset: c128f959642a70cbff3e58cf41509eb0364bd392
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
- Description modified (diff)
comment:4 Changed 6 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:5 Changed 6 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
I can install the scripts in the correct location and run them using the batch script without this change. I have a different failure in using the scripts, but it seems to have nothing to do with finding git. If I check the change, the new script fails on the xcopy command with Invalid number of parameters. The last path in the xcopy command needs to be surrounded by quotes since there are spaces in the path. What was the original error in running the scripts that caused this ticket to be generated?
comment:6 Changed 6 years ago by Dan Nixon
The original script assumes Git is installed in a certain location, which for me it wasn't.
comment:8 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Michael Reuter
OK. Mine must have been installed under the assumed location. I'll checkout the fix.
comment:11 Changed 6 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10331_install_git_macros_finds_git'
Full changeset: 7da41612161e534f45e28ea83ec6f70410afffe7
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11173
