Ticket #10339 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Tube Gap Calculation Modifications

Reported by: Owen Arnold Owned by: Vickie Lynch
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By: #10254
Blocking: Tester: Owen Arnold

Description

Here are a few things I noted while validating #10254. Probably best to spawn off separate tickets for these.

  • MaskBTP does not include SXD. Not sure how IntegratePeaksMD would work with this, but it currently stops processing with the following message: 
    Error in execution of algorithm MaskBTP:
Instrument SXD not in the allowed list
  at line 61 in '/Applications/MantidPlot.app/plugins/python/algorithms/MaskBTP.py'
Can't execute MaskBTP algorithm for this instrument to set edge for IntegrateIfOnEdge option
  • peak::findDetector. Code is OK, but needs some additional comments to explain what is happening. I understand it, but others may not.
  • peak::findDetector. Multiple if statements and returns. Undesired.
  • New detectorQ code, the algorithm Andrei derived needs more explanation than is given in the code. This is the important part of the processing of the edge calculation.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Refs #10339 MaskBTP works for SXD

Changeset: e7658d5d1d91a3c9254d4b1bec8bdd5cc5549286

comment:2 Changed 6 years ago by Vickie Lynch

Refs #10339 comments to describe edge calculation added

Changeset: 90f70d06c84f484ab77794e18719f0d98009db7c

comment:3 Changed 6 years ago by Vickie Lynch

Refs #10339 only one return in findDetector and add comments

Changeset: 15ef547f1525ba4c8df0b218ef342b5a80179f7f

comment:4 Changed 6 years ago by Vickie Lynch

Refs #10339 fix conflict

Changeset: 92c8b42a7cc5d4c1812fe1de57d4388f5a63f6f0

comment:5 Changed 6 years ago by Vickie Lynch

  • Status changed from new to assigned

comment:6 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to verify
  • Resolution set to fixed

Test with SXD: 

Load(Filename='SXD23767.raw',OutputWorkspace='SXD23767')
ConvertToDiffractionMDWorkspace(InputWorkspace='SXD23767',OutputWorkspace='mdws',OneEventPerBin='0')
FindPeaksMD(InputWorkspace='mdws',MaxPeaks='10',OutputWorkspace='peaks')
IntegratePeaksMD(InputWorkspace='mdws',PeakRadius='0.02',BackgroundInnerRadius='0.024',BackgroundOuterRadius='0.029999999999999999',PeaksWorkspace='peaks',OutputWorkspace='integrated',IntegrateIfOnEdge=False)

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10339_MaskBTP_SXD'

Full changeset: ​fd9489c78e090474f826cbc1a77eea07f05417fd

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11181

Note: See TracTickets for help on using tickets.