Ticket #10340 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Some indirect algorithms do not save their history

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

Currently:

  • InelasticIndirectRedution
  • IndirectTransmissionMonitor
  • SofQWMoments

do not save their history.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Summary changed from Some new indiretc algorithms do not save their history to Some new indirect algorithms do not save their history

comment:3 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:4 Changed 6 years ago by Dan Nixon

  • Summary changed from Some new indirect algorithms do not save their history to Some indirect algorithms do not save their history

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Refactoring in SofQWMoments

Refs #10340

Changeset: 8f9facd7ca8fff3c3879e971fc78fd6cb7dd7d68

comment:6 Changed 6 years ago by Dan Nixon

Add history of a WS group to children on algo

Refs #10340

Changeset: bd8c3dc2e69817f185e84abb23e4607febe3bcc5

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Load IRS26173.raw and IRS26176.raw
  • Run IndirectTransmissionMonitor with 26176 as the sample and 26173 as the can
  • The output workspace is a workspace group with 3 workspaces
  • On master none of these will have a history and selecting Show History from the context menu does nothing
  • With the fix applied all three workspaces have a history containing the two Load executions and a single execution of IndirectTransmissionMonitor
  • Check no tests were broken

comment:8 Changed 6 years ago by Dan Nixon

Add commenting to changes

Refs #10340

Changeset: 1aa1b3c5e68b3b8a7d01d80328dc88abd5137c3f

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10340_algorithm_history_for_workspace_group_output'

Full changeset: ​30e07785c5378d08adaa074787017dc323d7124a

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11182

Note: See TracTickets for help on using tickets.