Ticket #10356 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Enable patch sensitivity for HFIR SANS

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.3
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

EQSANS has a way to create a sensitivity file where areas of the detector can be 'patched'. For instance, if the signal at the beam center is blocked, the user can mask that area and the sensitivity calculation will compute the average sensitivity along the tube corresponding to each masked pixel and assign that value them. The result is a sensitivity workspace that covers the whole detector.

We would like to enable that functionality for HFIR SANS.

Change History

comment:1 Changed 6 years ago by Mathieu Doucet

Re #10356 added patch sensitivity to HFIR SANS

Changeset: 6bb9f1de27b2d9f8569a88854579e765af64df21

comment:2 Changed 6 years ago by Mathieu Doucet

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Mathieu Doucet

  • Status changed from assigned to verify
  • Resolution set to fixed

To test:

  • Start the HFIR reduction UI
  • Enter a file in the sensitivity box on the Detector tab (check the apply sensitivity box first).
  • Check the patch sensitivity box, then click the Patch button to draw a patch by using the mask tool.
  • Click the Compute Sensitivity button.
  • A workspace named "sensitivity" should be produced. Right click on it and select the option to show the detector. You should see the detector, and the areas that you masked should now be replaced by non-zero values. The values should be constant along the tubes, so you might see strips.

comment:4 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:5 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Hi Mathieu, please can you check this, it seems that the branch has not been fully merged to develop.

ERROR: Branch 'feature/10356_hfir_patch_sensitivity' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.

Contact Mathieu Doucet on doucetm@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10356_hfir_patch_sensitivity and let you know when it passes testing on the buildservers so you can start testing.

comment:6 Changed 6 years ago by Mathieu Doucet

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Raquel Alvarez Banos to Andrei Savici

comment:8 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10356_hfir_patch_sensitivity'

Full changeset: 7c049742e1fac0154d06a304ff61016b987cce62

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11198

Note: See TracTickets for help on using tickets.