Ticket #10368 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Apply corrections preview plot

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: spencer.howells@… Blocked By: #10277
Blocking: #10278, #10345, #10409, #10492 Tester: Raquel Alvarez Banos

Description (last modified by Dan Nixon) (diff)

Add a miniplot to Apply Corrections to show the contributions and remove the option to plot them from Output group.

Also group as follows:

  • Input
    • File
  • Options
    • Geometry
    • Can
    • Corrections
  • Preview
    • Miniplot

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Initial changes to UI

Refs #10368

Changeset: 60cb51ea198ba5ee2cb1487f63efc0257fcba8e9

comment:3 Changed 6 years ago by Dan Nixon

  • Blocked By 10277 added

Need the nice plotting and graph functions from IndirectTab.

comment:4 Changed 6 years ago by Dan Nixon

Added preview plotting

Refs #10368

Changeset: 7bb8ca9d7e7c8324624084791ce1af3951b5a8a9

comment:5 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:6 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10277_indirect_bayes_fit_preview_plots' into feature/10368_apply_corrections_preview_plot

Refs #10368

Changeset: 8778d12f5fb24e4d963835d346a9ab8dc060353f

comment:7 Changed 6 years ago by Dan Nixon

Wor in progress moving IDA to IndirectTab

Refs #10368

Changeset: deb3379896b19f0bce0a7ad1f38594988416acbc

comment:8 Changed 6 years ago by Dan Nixon

Correct Python error, general refactoring

Refs #10368

Changeset: cac2596d72c579c7cb29d26c7587604442662030

comment:9 Changed 6 years ago by Dan Nixon

Better plotting for corrections only

Refs #10368

Changeset: 21657e9c43702f573c776c505215c0156ca64e35

comment:10 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Data Analysis > Apply Corections
  • Load sample irs26176_graphite002_red.nxs, it should be plotted in the preview plot
  • Select Cylinder geometry and load corrections file irs26176_graphite002_cyl_Abs.nxs
  • Run, the corrected spectrum should be plotted as green curve
  • Load can file irs26173_graphite002_red.nxs
  • Run, the can should be plotted as a red curve
  • Disable corrections
  • Run, the shape of the corrected curve will change
  • Change the selected spectrum and notice the preview plot change
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:11 Changed 6 years ago by Dan Nixon

Add plot legend to UI

Refs #10368

Changeset: e18479375eb4dbea5bae7e9eb3a38b56bc86e94e

comment:12 Changed 6 years ago by Dan Nixon

Add spectra selection to apply corr preview plot

Refs #10368

Changeset: 9f31666209c2f6838467a371a3ddef09f63643d7

comment:13 Changed 6 years ago by Dan Nixon

Clean up some plotting code in IDA

Refs #10368

Changeset: 608d4a1e7d9f92cf589355bf5102d891625eeaf3

comment:14 Changed 6 years ago by Dan Nixon

  • Blocking 10278 added

comment:15 Changed 6 years ago by Dan Nixon

  • Blocking 10409 added

(In #10409) Need an algorithm runner, added one in #10368.

comment:16 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10368_apply_corrections_preview_plot

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ConvFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Quasi.cpp

Refs #10368

Changeset: 0805584c08e09049e7c02bbdf8c240c7bb080159

comment:17 Changed 6 years ago by Dan Nixon

Correct error in merge

Refs #10368

Changeset: e611f102f1a6b6df1b993786fa5bc3f1e06fe925

comment:18 Changed 6 years ago by Dan Nixon

Only change the UI file where needed

Refs #10368

Changeset: b0f26512e2a41becacfe6b1bd7e3008ffec1ea04

comment:19 Changed 6 years ago by Dan Nixon

Auto load the can Refs #10368

Changeset: 12baba183c60f863def56872a21d81f3c09707d0

comment:20 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:21 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:22 Changed 6 years ago by Dan Nixon

  • Blocking 10345 added

comment:23 Changed 6 years ago by Dan Nixon

Few fixes to keep clang happy

Refs #10368

Changeset: 7cce79a844a4ddfa9a4810faa584808a9e6e1592

comment:24 Changed 6 years ago by Dan Nixon

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:25 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Disable input validation on change on CalcCor

Refs #10368

Changeset: 8846787587c1d37824d27b058b8db90f3a955c7a

comment:26 Changed 6 years ago by Dan Nixon

Use correct Python slot name

Refs #10368

Changeset: b36a204287e0c49da534a32874df3183227e49d8

comment:27 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10368_apply_corrections_preview_plot' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectTab.h

Refs #10368

Changeset: c9ba960a94bacca33682df19d3f050392f5d6a1b

comment:28 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10368_apply_corrections_preview_plot

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectTab.h

Refs #10368

Changeset: 45f2acf2e0947f8763e93511ba53df2d256661ec

comment:29 Changed 6 years ago by Dan Nixon

Correct Python execution slot name in IDA and Bayes

Refs #10368

Changeset: 7cc01ba53e9381b0d5fbebf087da645d3d3badb9

comment:30 Changed 6 years ago by Dan Nixon

Remove unused plot contrib option

Refs #10368

Changeset: 25d1922275db7c6d60f0531f2055b9531393c469

comment:31 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:32 Changed 6 years ago by Dan Nixon

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:33 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Remove calc and can plots when loading new data

Refs #10368

Changeset: e92ca5c99f71e557f1df095946a5c98e6ef00cb6

comment:34 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:35 Changed 6 years ago by Dan Nixon

  • Blocking 10492 added

(In #10492) IDATab must inherit from IndirectTab for this to work on IDA.

comment:36 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:37 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I get an unexpected exception when following the testing steps. When I load sample file irs26176_graphite002_red.nxs and corrections file irs26176_graphite002_cyl_Abs.nxs, the preview window is updated correctly. But when I try to run, the following output is written to the Results Log window:

ValueError: Mismatch: num of spectra in irs26176_graphite002_cyl_ass and inputWS

at line 17 in '<Interface>' caused by line 999 in 'C:/Users/dsl37522/mantid-code/mantid/Code/Mantid/scripts/Inelastic\IndirectDataAnalysis.py' caused by line 894 in 'C:/Users/dsl37522/mantid-code/mantid/Code/Mantid/scripts/Inelastic\IndirectDataAnalysis.py'

Unexpected exception: Data Object search object

comment:38 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:39 Changed 6 years ago by Dan Nixon

  • Status changed from verify to closed

Merge branch 'feature/10277_indirect_bayes_fit_preview_plots' into feature/10368_apply_corrections_preview_plot

Refs #10368

Full changeset: 8778d12f5fb24e4d963835d346a9ab8dc060353f

comment:40 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10368_apply_corrections_preview_plot

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ConvFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Quasi.cpp

Refs #10368

Full changeset: 0805584c08e09049e7c02bbdf8c240c7bb080159

comment:41 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10368_apply_corrections_preview_plot

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectTab.h

Refs #10368

Full changeset: 45f2acf2e0947f8763e93511ba53df2d256661ec

comment:42 Changed 6 years ago by Raquel Alvarez Banos

Merge remote-tracking branch 'origin/feature/10368_apply_corrections_preview_plot'

Full changeset: 2a98c5c29b455f21c48b782998749848445b43d1

comment:43 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10368_apply_corrections_preview_plot' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectTab.h

Refs #10368

Changeset: c9ba960a94bacca33682df19d3f050392f5d6a1b

comment:44 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11210

Note: See TracTickets for help on using tickets.