Ticket #10381 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ConvFit should log if result was convolved

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

The value of the convolve check box should be added to the sample logs for the output workspace.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add convole to sample logs

Also correct a Qt warning

Refs #10381

Changeset: 475a6a9982dec495fd93b23a051d648e17167198

comment:3 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Data Analysis > ConvFit
  • Load sample irs26176_graphite002_red.nxs
  • Load resolution irs26173_graphite002_res.nxs
  • Select One Lorentzian as the Fit Function
  • Click Run, open sample logs for one of the result workspaces
  • Verify that the convolve_members entry exists and should match the state of the Convolve checkbox

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10381_convfit_convole_option_save_in_logs'

Full changeset: ​6e6cf6eb91250db06613d21bb0cbf238e37fc970

comment:7 Changed 6 years ago by Federico M Pouzols

Works like a charm. The value of the convolve check box should be added to the sample logs for the output workspace.

comment:8 Changed 6 years ago by Alex Buts

refs #10381 Doctests

Changeset: 56b7a3ce0276fe8588203124b26537fc301e2820

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11223

Note: See TracTickets for help on using tickets.