Ticket #10383 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

FITS loader - Change how data is stored.

Reported by: John Hill Owned by: John Hill
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez Banos

Description (last modified by John Hill) (diff)

Revert LoadFITS to loading multiple files as individual workspaces in a group.

Changes will need to be made to SaveNXTomo algorithm to keep it inline with the new structure.

Testing:

1: Load the files attached to http://trac.mantidproject.org/mantid/ticket/10397 (select all at once)

2: Check the files are loaded into separate workspaces into a workspace group

3: Run SaveNXTomo algorithm on the group, all workspaces should be saved into a single file

4: Open the nexus file in HDFView and check entry1/tomo_entry/data/data to see that it contains 2 rows with data in.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by John Hill

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by John Hill

Refs #10383 initial changes to loader

Changeset: a17ff243488e29ff181f96e02caad2f16ff3a56a

comment:4 Changed 6 years ago by John Hill

Refs #10383 change savenxtomo to work with new structure

Changeset: 5bcc46b45e6c2ea7e0fceff4483f6d2a83f25f91

comment:5 Changed 6 years ago by John Hill

Refs #10383 fixing a few errors

Changeset: df139cbd2c1db4e7a4efed4456a53763058b5b70

comment:6 Changed 6 years ago by John Hill

Refs #10383 fixing a few errors

Changeset: 857aedfa25c51214d105a464378124b1ec2f2ca3

comment:7 Changed 6 years ago by John Hill

Refs #10383 fixing a few errors

Changeset: 8fbeafbe0921b4d86c8254f91a88d8f5e2f650b1

comment:8 Changed 6 years ago by John Hill

Refs #10383 fixing some cpp check warnings

Changeset: 9ad71662564a0da78f5a8161cffeadc934a77634

comment:9 Changed 6 years ago by John Hill

Refs #10383 fix for build warning

Changeset: ac3a959c39b8d7101d1e1072b06c32c20a5e5a60

comment:10 Changed 6 years ago by John Hill

Refs #10383 small changes

Changeset: 327d446329ab1217062a36596357851a3d49a186

comment:11 Changed 6 years ago by John Hill

Refs #10383 swapping byte order and adding support for scaling data

Changeset: 55ef1b41555ab28b7bcf402d22a647d8cc8a757b

comment:12 Changed 6 years ago by John Hill

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:13 Changed 6 years ago by John Hill

  • Description modified (diff)

comment:14 Changed 6 years ago by John Hill

  • Description modified (diff)

comment:15 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:16 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The code works fine, it works as described. But there are a couple of cpp checks that need to be fixed.

comment:17 Changed 6 years ago by John Hill

  • Status changed from reopened to inprogress

Refs #10383 suppressing invalid cppcheck warnings

Changeset: 0bf0619943eb23ffabf81d66c8be03afb44c563e

comment:18 Changed 6 years ago by John Hill

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:19 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying

comment:20 Changed 6 years ago by John Hill

  • Status changed from verifying to closed

Merge branch 'master' of github.com:mantidproject/mantid into feature/10383_fits_workspace

Full changeset: bf0dd8d8a3e2977437ecb8eff0052a4f6c96dc89

comment:21 Changed 6 years ago by John Hill

Merge remote-tracking branch 'origin/master' into feature/10383_fits_workspace

Full changeset: 94de957c5ea21a75789f6c69f944582509146c6a

comment:22 Changed 6 years ago by Raquel Alvarez Banos

Merge remote-tracking branch 'origin/feature/10383_fits_workspace'

Full changeset: cb75525d7a1aa56113a9d93ce357fc21a2280a73

comment:23 Changed 6 years ago by John Hill

Refs #10383 fixing a few errors

Changeset: 8fbeafbe0921b4d86c8254f91a88d8f5e2f650b1

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11225

Note: See TracTickets for help on using tickets.