Ticket #10390 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Implement the Image methods for MatrixWorkspace

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: blocker Milestone: Release 3.3
Component: Framework Keywords:
Cc: John.Hill@… Blocked By:
Blocking: Tester: Federico M Pouzols

Description

See the design doc here

​https://github.com/mantidproject/documents/blob/master/Design/WorkspaceImageMethods.md

Change History

comment:1 Changed 6 years ago by Roman Tolchenov

Re #10390. Added image get functions and unit tests.

Changeset: 3a9419915d492c15c5b27447afdf819d7eb6dcde

comment:2 Changed 6 years ago by Roman Tolchenov

Re #10390. Use x values instead of indices.

Changeset: cfb3f3cf33385e50eaf27deadb73343f58786aed

comment:3 Changed 6 years ago by Roman Tolchenov

Re #10390. Added image setting methods.

Changeset: efb09799634ef6152a32cd07fed92f24e3faa87d

comment:4 Changed 6 years ago by Roman Tolchenov

Re #10390. Changed loops to parallel

Changeset: 11bdce3c2deeac5960ea09bc58d596fc2ba91e0b

comment:5 Changed 6 years ago by Roman Tolchenov

Re #10390. Fixing include file name.

Changeset: d15aea345cdae14a59d782346914ff8e25defbc0

comment:6 Changed 6 years ago by Roman Tolchenov

Re #10390. Fix compile warnings.

Changeset: 7773884ce6263bf5dec3964a9573e43fcefd2180

comment:7 Changed 6 years ago by Roman Tolchenov

  • Status changed from new to assigned

To test:

  • Review the code
  • Check the unit tests

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:10 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

This seems to be working perfectly fine:

  • Unit tests pass.
  • The new methods specified in the design doc have been added, and also the new typedefs MantidImage_sptr and MantidImage.
  • The code looks sound and well documented. The algorithms process image rows in parallel.
  • It comes with a good set of new tests.

comment:11 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/feature/10390_matrix_workspace_image_methods'

Full changeset: ​958e92fd6edf0e0b19078669f9353e734d8cf052

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11232

Note: See TracTickets for help on using tickets.