Ticket #10396 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Removing dead pixels in calibration

Reported by: Peter Peterson Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: zhouw@… Blocked By:
Blocking: Tester:

Description

If a pixel doesn't have as many counts as either MinimumPeakHeight or MinimumPeakHeightObs then it should be summarily ignored. This may already be the case, but it should be checked out.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Peterson

  • Owner changed from Peter Peterson to Wenduo Zhou

comment:3 Changed 6 years ago by Wenduo Zhou

For tester

In GetDetOffsetsMultiPeaks, a dead pixel is defined as a detector has zero counts. It is masked in output MaskWorkspace. A spectrum is also masked if there is no peak found to calculate offset. MinimumPeakHeight and MinimumPeakHeightObs are used as the criteria for peak finding.

The documentation is expanded to cover this issue.

Last edited 6 years ago by Wenduo Zhou (previous) (diff)

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Refs #10396. Improved documentation.

Changeset: 337227fdab51394c77f36e404a3fa00073408baa

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Pete Peterson

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/10396_rm_dead_pixels'

Full changeset: ​109123fb998ce2b2aa4101182db7a4b67ff7bc6c

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11238

Note: See TracTickets for help on using tickets.