Ticket #10410 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ElasticWindow should support Sqw

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #10411
Blocking: Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

Currently ElasticWindow gives an error when loading an Sqw workspace.

It should be able to support Sqw.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Blocked By 10411 added

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)
  • Blocked By 10411 removed

comment:3 Changed 6 years ago by Dan Nixon

  • Blocked By 10411 added

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added ability to use Sqw to ElasticWindow

Refs #10410

Changeset: 582b7575cb8e6bf9bc9e50ff641b609b7b184d9f

comment:6 Changed 6 years ago by Dan Nixon

Fix minor cppcheck warning

Refs #10410

Changeset: 666a1c53b777e175bb92dd6b99c86816586c22a7

comment:7 Changed 6 years ago by Dan Nixon

Add unit test for using S(Q,w)

Refs #10410

Changeset: 195276ecb5ac33afe81f5c623dc5c06686510cf6

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Verify ElasticWindow unit tests are passing
  • Load irs53664_graphite002_red and irs53664_graphite002_sqw from system tests
  • Run ElasticWindow with both data sets using parameters:
    • Range1Start: -0.05
    • Range1End: 0.05
    • Range2Start: 0.08
    • Range2End: 0.1
  • Verify that the output is reasonable:
    • The number of points should be equal to the number of spectra in the sample data (51 for red, 14 for Sqw).
    • The intensity of the result from S(Q,w) data will be higher than that from reduced data.
    • The curves are not expected to be identical.

comment:9 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:10 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10410_elasticwindow_algo_should_support_sqw'

Full changeset: 801b525f3ca643bd1e17825a69581ddc0df41fed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11252

Note: See TracTickets for help on using tickets.