Refactor the Spectrum Viewer & RefDetectorViewer

[Dan Nixon]

The spectrum viewer does not follow the code style of the rest of Mantid and as such is a pain to maintain.

It should be tidied up, the code style improved and a few small issues I noticed:

• The run title should be trimmed
• The Vertical Graph Info label should be in the same layout as the vertical graph info
• As much as possible the two curve plots should line up with the image plot

[Dan Nixon]

Work in progress: moving to Mantid code style

Refs #10441

Changeset: 94269051586197ef671958c60fe2f7bf372176a7

[Dan Nixon]

Spectum Viewer now follows code style

Refs #10441

Changeset: ebd9e7d100d21ddf52379d7f40eb5e39af76d68a

[Dan Nixon]

Work in progress: refactoring RefDetectorViewer

Refs #10441

Changeset: a7c4b6d248c5fb1bd2265935915836de99bcf243

[Dan Nixon]

The RefDetectorViewer uses a lot of the code from Spectrum Viewer, some of it needs changed alongside the changes to Spectrum Viewer so may as well be refactored now as well.

[Dan Nixon]

More refactoring in RefDetectorViewer

Refs #10441

Changeset: 803eddff89beda12e723d6b33e2fe21c1bf4bea7

[Dan Nixon]

Make the UI keep it's shape a bit better

Refs #10441

Changeset: cb44e46987568d912fc5bf3b2deb800f8128e9ca

[Dan Nixon]

Refectored logging in SPectrum View

Refs #10441

Changeset: 54741532c073f2bd262aa5d14ee8c2ecdc11f44f

[Dan Nixon]

Improve resizing on Spectrum View

Refs #10441

Changeset: 0ea073946b4aabd30e3e0b96bd3fdcdab9fae6aa

[Dan Nixon]

Trim text for title and info lists

Refs #10441

Changeset: 069ddc7f3a435ee79addd1c95c4d28a4a44693a7

[Dan Nixon]

Don't use void pointers

Refs #10441

Changeset: 063df9a5e34fcb993649615bcec7a3cdeaee518b

[Dan Nixon]

Correct the close window slot name

Refs #10441

Changeset: 5e421f7fb24eafa9e8642760f91d9e9e0ffd26f9

[Dan Nixon]

Better documentation in SVConnections

Refs #10441

Changeset: d478622c212bfaa55074ca06ae06a743671de980

[Dan Nixon]

Also this commit: 69ddf5afaef76ffbfd8dfec6df9983fedae7d404

[Dan Nixon]

Trim text for text boxes

Refs #10441

Changeset: a10a8227df6ef0256d51b217ed2ef13286fa1755

[Dan Nixon]

To test:

• Load a workspace (any matrix workspace should be fine, >50 spectra recommended)
• Move the splitter between the image and spectra graph, the splitter between the vertical graph info and vertical graph should move to keep graphs in line.
• Do the same as above in reverse.
• Select points on each graph, ensure data is still shown correctly
• Code review to ensure Mantid code style is met

[Dan Nixon]

Fix failing clang OSX build

Refs #10441

Changeset: a1ffb175acdbb4441695b5a004ddb970407035d7

[Dan Nixon]

Correct a Clang compiler warning

Refs #10441

Changeset: 4a92923c19bc091098e985fc387837a423e8221c

[Harry Jeffery]

• RefImageView.cpp:65 - image_display does not need to exist. You could just use m_imageDisplay.
• RefIVConnections.cpp:283-287 - These do not need to be destroyed by us. They all have parents, so Qt's QObject hierarchy will clean them up for us naturally.
• RefIVConnections.cpp:573 - If an exception is thrown before delete[] we leak memory. We should use a std::vector<unsigned int> here instead.
  • Since we know the size in advance we can save the cost of resizing by telling the constructor to fill it with total_colors items each with a value of 0: std::vector<unsigned int> rgbData(total_colors, 0);
  • Also, as vectors guarantee contiguous storage, the raw access on line 590-591 can be achieved with QImage image(&rgbData[0], static_cast<int>(total_colors), 1, QImage::Format_RGB32);
• DataArray.h:131 - We could a boost::shared_ptr<float> here to make the ownership more explicit. It's also worth wondering if this couldn't be changed into a boost::shared_ptr<std::vector<float>>
• ArrayDataSource.h:47 - Once again, why not use is a boost::shared_ptr<float> or even a shared pointer to a std::vector<float>.

Summary: Let's eliminate the use of pointers to raw dynamic arrays and replace them with pointers to std::vector<float>s and wrap them in appropriate smart pointers.

[Dan Nixon]

Removed use of arrays in colour images

Refs #10441

Changeset: cee589c06f6ac0ad4e3a2227e35dcf7b90161a5d

[Dan Nixon]

Replace arrays with vectors

Refs #10441

Changeset: 859a1956d0f04f5bd8dc18dfebe2302648dd0a00

[Dan Nixon]

Use const shared pointers for DataArray

Refs #10441

Changeset: 9ff3dc339762b9f88040f1a0c4a330af81f26ccd

[Dan Nixon]

Replace SpectrumDataSource with shared pointers

Refs #10441

Changeset: 4af1040b83989dd55885212faf6eca4f27d8853e

[Dan Nixon]

Correct failing builds

Refs #10441

Changeset: 6daf8d595a100f8a9ad46aea7b103af09883b7d5

[Dan Nixon]

Correct demo application build

Refs #10441

Changeset: 5b53a7739902d770dcc78823a30f6c2f243cadda

[Dan Nixon]

Remove Spectrum View demo application

Refs #10441

Changeset: 27c3b8e2f34a5785261df4c4a135cfe67461f82f

[Harry Jeffery]

Merge remote-tracking branch 'origin/feature/10441_refactor_spectrum_viewer'

Full changeset: ​bf6d611be35b73645a5be717cdb77501c414dbb9

[Stuart Campbell]

This ticket has been transferred to github issue ​11283