Ticket #10443 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add LoadSassena to Indirect Simulation interface

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By: #10277
Blocking: Tester: Harry Jeffery

Description

There should be a tab on Indirect Simulation for loading Sassena files.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Summary changed from Add LoadSasena to Indirect Simulation interface to Add LoadSassena to Indirect Simulation interface

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added new Sassena UI skeleton

Refs #10443

Changeset: f29fc50dac7a6d84ac928d0d905aa48d4b6660ec

comment:3 Changed 6 years ago by Dan Nixon

  • Blocked By 10391 added

Added algorithm runner here.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:4 Changed 6 years ago by Dan Nixon

Added Sassena algorithm to UI

Refs #10443

Changeset: 56478f49b0e52f962e9455b314d9a8b8e5fb411a

comment:5 Changed 6 years ago by Dan Nixon

  • Blocked By 10277 added

Indirect tab has a BatchAlgorithmRunner needed to run SaveNexus.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:6 Changed 6 years ago by Dan Nixon

Added save algorithm, tidy UI

Refs #10443

Changeset: 504b62f01cd11dea463859e3e622ee6cfb543231

comment:7 Changed 6 years ago by Dan Nixon

  • Blocked By 10257 added

Would be nice to not have to add Python just for the sake of plotting.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:8 Changed 6 years ago by Dan Nixon

Added tooltip for time unit

Refs #10443

Changeset: bc669c5a4a664983c324b3bbd7fbdc8875a05985

comment:9 Changed 6 years ago by Dan Nixon

  • Blocked By 10391 removed

If making IndirectSimulationTab inherit from IndirectTab whatever was done here is irrelevant.

comment:10 Changed 6 years ago by Dan Nixon

Add unit suffix for time unit

Refs #10443

Changeset: 4d1227a83d69153d82877f80af24460f739e9990

comment:11 Changed 6 years ago by Dan Nixon

  • Blocked By 10257 removed

Not going to rely on this, when #10257 is done I will have a fair amount of Python to remove anyway.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10443_sassena_indirect_simulation_tab

Refs #10443

Changeset: f9489930c5906d8b1deec1af10174967901f3fde

comment:13 Changed 6 years ago by Dan Nixon

Simulation tab inherit from IndirectTab

Refs #10443

Changeset: 169298c6f561c51fc8245adef536705884dd683f

comment:14 Changed 6 years ago by Dan Nixon

Use batch alg runner in Sassena tab

Refs #10443

Changeset: 44c0913828d869dd80eb0642a58d37cd9eb8f9e6

comment:15 Changed 6 years ago by Dan Nixon

Add plotting to Sassena tab

Refs #10443

Changeset: 9d68f621c614cd3d4ff44e817507691da462abad

comment:16 Changed 6 years ago by Dan Nixon

Handle workspaces already in ADS

Refs #10443

Changeset: 4a4b87bcf32ca5b1d4539dd92ee44fe659bfe744

comment:17 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectTab.h

Refs #10443

Changeset: de21ab7b4f7be0431426d18eece3472ff19686c6

comment:18 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Simulation > Sassena
  • Load file AutoTestData/UsageData/loadSassenaExample.h5
  • Check plot result and save result
  • Run, workspace should be saved to default save directory and a plot generated
  • Change time to 10ps and run again, plot X range should be 10x previous range

comment:19 Changed 6 years ago by Dan Nixon

Revert "Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop"

This reverts commit de21ab7b4f7be0431426d18eece3472ff19686c6, reversing changes made to 59889cbcfbe882b1714ba04a8cf7b2e96283e065.

Refs #10443

Changeset: 23d19f4ef380f3b4992121698eb30a15b93c9fc8

comment:20 Changed 6 years ago by Dan Nixon

Keep already used function name

Refs #10443

Changeset: 509d9140ac09ff46a0b9e3222ed74ebe420193d8

comment:21 Changed 6 years ago by Dan Nixon

Revert "Revert "Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop""

This reverts commit 23d19f4ef380f3b4992121698eb30a15b93c9fc8.

Refs #10443

Changeset: d74fc2d41ef427fb941d00cf685d6495dccf471a

comment:22 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop

Refs #10443

Changeset: 1190f0767b5bdbca050661ed85d9fbd6ef698cb3

comment:23 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:24 Changed 6 years ago by Dan Nixon

Use existing signal name for running Python

Refs #10443

Changeset: 3064c16bf4bf44d55740d8424dc7b137225f818d

comment:25 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:26 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'feature/10391_moldyn_algorithm' into feature/10443_sassena_indirect_simulation_tab

Refs #10391

Full changeset: ​3084fcf8e0ab0e9f146c8d9ebbbe52fc6981e04e

comment:27 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10443_sassena_indirect_simulation_tab

Refs #10443

Full changeset: ​f9489930c5906d8b1deec1af10174967901f3fde

comment:28 Changed 6 years ago by Harry Jeffery

Merge remote-tracking branch 'origin/feature/10443_sassena_indirect_simulation_tab'

Full changeset: ​6bb6db07e9c99bcf0329d744fdb004dbcd88fd75

comment:29 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectTab.h

Refs #10443

Changeset: de21ab7b4f7be0431426d18eece3472ff19686c6

comment:30 Changed 6 years ago by Dan Nixon

Revert "Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop"

This reverts commit de21ab7b4f7be0431426d18eece3472ff19686c6, reversing changes made to 59889cbcfbe882b1714ba04a8cf7b2e96283e065.

Refs #10443

Changeset: 23d19f4ef380f3b4992121698eb30a15b93c9fc8

comment:31 Changed 6 years ago by Dan Nixon

Revert "Revert "Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop""

This reverts commit 23d19f4ef380f3b4992121698eb30a15b93c9fc8.

Refs #10443

Changeset: d74fc2d41ef427fb941d00cf685d6495dccf471a

comment:32 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10443_sassena_indirect_simulation_tab' into develop

Refs #10443

Changeset: 1190f0767b5bdbca050661ed85d9fbd6ef698cb3

comment:33 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11285

Note: See TracTickets for help on using tickets.