Ticket #10447 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SpectrumView should have a refresh/update method to change the workspace data

Reported by: Federico M Pouzols Owned by: Dan Nixon
Priority: minor Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez Banos

Description

This method would make it possible to update the Spectrum View window with a different workspace/underlying data.

The idea is that if one is using a single spectrum viewer instance, it should not be necessary to close it and open a new one to visualize a different workspace.

This seems to be mostly (if not fully) implemented in SpectrumView::renderWorkspace(), but it needs to be tested (potentially amended) and documented.

This is related to/motivated by ticket #8091.

Destroying a spectrum viewer window and creating a new one does not seem to take a significant amount of time, at least in the few tests that I did. So I'd say that ticket has a low benefit/effort ratio and consequently low priority, as it may require testing of proper initialization, etc.

This ticket is a brother of #10445 and #10446.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Owner set to Dan Nixon

comment:2 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.3

Gave this a quick test and seems to work fine, will do some more testing and documentation to what the function actually does.

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Better documentation of SpectrumView functions

Start supporting workspace refresh events.

Refs #10447

Changeset: 0a5f881c3d72d5a07242728e6400e27b495304aa

comment:4 Changed 6 years ago by Dan Nixon

Remove old plots on new data

Refs #10447

Changeset: 1c364b9e994741fd2ff566f9f6f7152cf8cb4f22

comment:5 Changed 6 years ago by Dan Nixon

To test:

  • Load a file (e.g. IRS26173.raw)
  • Open the spectrum viewer for the workspace
  • Select a region on the colour plot so that data is shown on the slice plots also
  • Load a different file (e.g. IRS26176.raw) with the same workspace name such that the original workspace is replaced
  • Notice the spectrum viewer is updated
  • Review function documentation

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:8 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Got this error when doing git test start:

$ git test start 10447 git fetch -p remote: Counting objects: 185, done. remote: Compressing objects: 100% (153/153), done. remote: Total 185 (delta 113), reused 66 (delta 32)R Receiving objects: 100% (185/185), 1017.90 KiB | 605.00 KiB/s, done. Resolving deltas: 100% (113/113), done. From github.com:mantidproject/mantid

a67a0a8..e928e4a develop -> origin/develop 8a98cc6..87d4e78 feature/10672_save_button_updates -> origin/feature/10672_save_button_updates

  • [new branch] feature/9915_add_usage_example_sinq_focus -> origin/feature/9915_add_usage_example_sinq_focus
  • [new branch] feature/9952_spectrogram_crash -> origin/feature/9952_spectrogram_crash

ERROR: Branch 'feature/10447_spec_view_refresh_function' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.

Contact Dan Nixon on dan@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10447_spec_view_refresh_function and let you know when it passes testing on the buildservers so you can start testing.

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:10 Changed 6 years ago by Dan Nixon

Should be fine now.

comment:11 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/10447_spec_view_refresh_function'

Full changeset: 5d1221493a6af3a276b8ecfb5252fd196a172f58

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11289

Note: See TracTickets for help on using tickets.