Ticket #10474 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Multi-dataset fitting interface: add graphical tool to set fitting intervals for each spectrum

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By: #8911
Blocking: #11088 Tester: Dan Nixon

Description

The tool should be similar to the one in PeakPickerTool. The data table in the interface should have two more columns for StartX and EndX. The columns should be synced with the graphical tool.

Change History

comment:1 Changed 6 years ago by Roman Tolchenov

  • Blocked By 8911 added

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:4 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:5 Changed 6 years ago by Roman Tolchenov

  • Milestone changed from Backlog to Release 3.4

comment:6 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #10474. Handle workspaces in DataController class.

Changeset: fd9f3be2d28a2eab79494f34a5eb7c85c953538e

comment:7 Changed 6 years ago by Roman Tolchenov

Re #10474. Added fitting range selector tool.

Changeset: 8ed05a275638f7f22496d1ed033f9fccaa925144

comment:8 Changed 6 years ago by Roman Tolchenov

  • Blocked By 11088 added

comment:9 Changed 6 years ago by Roman Tolchenov

  • Blocking 11088 added
  • Blocked By 11088 removed

comment:10 Changed 6 years ago by Roman Tolchenov

Re #10474. Methods for setting the range.

Changeset: a382c0f13ecf100791b38b2152ab22ec532e5a80

comment:11 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/master' into feature/10474_set_fitting_interval_tool

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/MultiDatasetFit.h Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit.cpp

Re #10474.

Changeset: 59a4d9e3713c173db24cf5abcac24640a1b90a74

comment:12 Changed 6 years ago by Roman Tolchenov

Re #10474. Connected the range selector and the data table.

Changeset: 61fa5300d39facb9c5b1fa2ec0aedf9c10e20152

comment:13 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #392.

comment:14 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:15 Changed 6 years ago by Roman Tolchenov

Re #10474. Fix rhel6 errors and gcc warnings.

Changeset: f5626350378f9264ced576544659467106c0be01

comment:16 Changed 6 years ago by Roman Tolchenov

Jenkins retest this please

comment:17 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #392 from mantidproject/feature/10474_set_fitting_interval_tool

Adding a fitting range tool to MultiDatasetFitting interface

Full changeset: ​9211b3cdf5577fd1281c6012fcb755c3deb1bb17

comment:18 Changed 6 years ago by Dan Nixon

If I was being really pedantic I would say it would be worth documenting the fact that double right click resets the range when the range tool is enabled, but seems to work fine.

comment:19 Changed 6 years ago by Roman Tolchenov

Opened #11371(​http://trac.mantidproject.org/mantid/ticket/11371) to address it.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11316

Note: See TracTickets for help on using tickets.