Ticket #10483 (closed: fixed)
Fix Coverity issues in ReflMainViewPresenter
| Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
m_view is dereferenced both before a null checked dereference, and after. So why are we null checking? Coverity suggests that all paths leading to the null check have a valid pointer, so the check is doubly superfluous, as there is no possibility of a null pointer, and if there were one, it wouldn't protect us in its current state.
Change History
comment:3 Changed 6 years ago by Harry Jeffery
Refs #10483 Fix coverity issue(s) in ReflMainViewPresenter
Changeset: 395f938fcc1c498921f5427877fe5dab070d9bac
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
- Verify that coverity issues 1249473 and 1249474 are resolved (On any build dated 4th Nov 2014 or later)
- Verify tests are passing
comment:5 Changed 6 years ago by Harry Jeffery
Refs #10483 Remove superfluous null pointer checks
m_view will always be a valid pointer as it's assigned and dereferenced in the constructor, and never altered afterwards.
Changeset: 135409a9a087963fe5fd3fc320ffc49c22638d1b
comment:6 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:7 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10483_refl_coverity_issues'
Full changeset: ae9818437786c7ff4b990421f91772532dc0ca65
