Ticket #10485 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

New Refl UI: Support group workspaces for processing

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

If group workspaces are passed to ReflectometryReductionOneAuto as pointers, it rejects them. However, if we pass them by name it'll handle them nicely.

To support some POLREF data, the new Refl UI needs to pass the input workspaces by name.

Attachments

PolRef_NR_test.tbl​ (1.8 KB) - added by Harry Jeffery 6 years ago.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Refs #10485 New Refl UI: Support group workspaces for processing

We needn't check the pointers here as loadRun would have thrown an exception on failure.

Changeset: 29e91096aaa34d3e2c0f9d53ca3fd0aaaa052494

Changed 6 years ago by Harry Jeffery

comment:4 Changed 6 years ago by Harry Jeffery

Testing

  • Processing the attached table should succeed.
    • Hint: use LoadReflTBL to load the table as a workspace that the Refl UI can open.
  • Verify unit tests are passing.
  • Inspect code changes.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:7 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10485_new_refl_ui_support_group_workspaces'

Full changeset: ​54b29322a4b39b11de2e5fea18e8b05432cf1411

comment:8 Changed 6 years ago by Federico M Pouzols

This is working, tests pass, and the new refl GUI is able to process the example table workspace.

Code changes replace pointers to workspaces with the corresponding workspace names.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11327

Note: See TracTickets for help on using tickets.