Ticket #10490 (closed: fixed)
Several download URLs used in the Mantid code need update/cleanup
| Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
When I was testing #10484 I realized that there can be issues with several links.
For example, in Code/Mantid/docs/conf-html.py, and Code/Mantid/Framework/Properties/Mantid.properties.template: http://download.mantidproject.org/scriptrepository/ should be http://www.mantidproject.org/ScriptRepository?
In Code/Mantid/docs/source/algorithms/CreateEmptyTableWorkspace-v1.rst, this link http://download.mantidproject.org/docs/current-release/python/html/api/generated/ITableWorkspace.html is also broken/outdated and should be http://www.mantidproject.org/Python_ITableWorkspace_v2, it seems.
Also, Code/Mantid/Framework/ICat/test/CatalogDownloadDataFilesTest.h uses http://download.mantidproject.org/videos/Installation.htm (inexistent).
And in the deb packages, Code/Mantid/Build/paraview-deb-packaging/README also refers to the old http://download.mantidproject.org/VatesDownload.psp a couple of times.
Actually, most of the 'download' URLs found in the code are outdated.
This looks simple to fix and I'd be happy to do it, but I think it requires a bit of double-checking/reviewing from a more experienced Mantid developer so that we keep the whole thing in sync.
I was not 100% sure about the 'Component' category for this ticket. It's mostly GUI-related, but not only.
Change History
comment:1 Changed 6 years ago by Federico M Pouzols
- Owner set to Federico M Pouzols
- Status changed from new to assigned
comment:2 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
Updated links in deb readme nd script, and in tests and doc, re #10490
Changeset: 1c1d2dd2d81a475b22b88780c3eeb0f2240181d1
comment:3 Changed 6 years ago by Federico Montesino Pouzols
update link to where the repo currently lives, re #10490
Changeset: d0ca3feac176c8c0eca218991efee43ea1cb831f
comment:4 Changed 6 years ago by Federico Montesino Pouzols
fix base repo url so that urls can be properly constructed, re #10490
Changeset: 962ac2ddf5f322e68be5b22fb19a56a0cae640ef
comment:5 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
The links have been updated as follows:
- conf-html.py was a false positive or its been updated since the ticket was opened. Nothing to do there
- Mantid.properties.template: better leave as it is or you'll break ScriptRepositoryTest! It was my misunderstanding, this url is apparently used to construct the repository url. Then the actual downloads will be like 'http://download.mantidproject.org/scriptrepository/repository.json'
- CreateEmptyTableWorkspace-v1.rst: link updated as proposed in the ticket description
- CatalogDownloadDataFilesTest.h: now the test downloads http://www.mantidproject.org/Documentation (the test was working but actually downloading an error page)
- Deb packages: the README has been updated, new link, new version, the sources are not patched, etc.
Everything seems fine and tests pass. Please make sure that these links make sense and that URLS are correct and up-to-date in the code. This should be enough for now. A more sophisticated approach (automatic link checker, etc.) would be possible, but most likely it's not worth the effort.
comment:6 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:7 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10490_download_URLs_cleanup'
Full changeset: 107d05e443ba8b3965f269b57dbd104e233059f7
