Ticket #10495 (closed: fixed)
Refl UI: Document discarded magic numbers
| Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.3 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Dan Nixon |
Description
The second bullet point of #10347 slipped through unresolved.
- Put a comment in all parameter files for the instruments POLREF, INTER, SURF, CRISP where LambdaMin, LambdaMax occur to indicate that LambdaMin and LambdaMax are hard limits, and will not be adjusted in software.
- Put a comment in https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L988-989 to explain the changes, but do not change the code. We don't want to mess with Max's results
Change History
comment:3 Changed 6 years ago by Harry Jeffery
Refs #10495 Document discarded magic numbers
Changeset: 177bdfcb32e532f05686b24096f05634c634f6bb
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
- Review changes.
comment:5 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:6 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10495_document_discarded_magic_numbers'
Full changeset: 7ba198026e4d55ba5c2626865fa9c51d9dbc132b
Note: See
TracTickets for help on using
tickets.
