Ticket #10516 (closed: fixed)
New Refl UI: Support multiple runs in a single row
| Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.3 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
Currently only one run can be handled in a single row, however the runs column is supposed to accept 1..n runs and join them for the user.
Given that the transfer functionality enters runs as such, it is important that this support be added soon.
Attachments
Change History
comment:2 Changed 6 years ago by Harry Jeffery
- Priority changed from major to critical
- Status changed from assigned to inprogress
comment:3 Changed 6 years ago by Harry Jeffery
Refs #10516 Support multiple runs per row
Changeset: 9131e1987af5abf5e1467b0dcab7319038df2a40
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
- The syntax for specifying multiple runs on a single row is firstRun+secondRun+thirdRun, etcetera.
- Multiple runs should be added together using the Plus algorithm to form a new workspace
- The resulting workspace should be usable for processing/reduction
- Process 13460+13462+13469+13470
- Check the history of the summed workspace
- It should have been constructed by adding the others together
- Select all the TOF workspaces and plot them
- Check the plot of summed workspace looks like the sum of the others
- Check the history of the summed workspace
comment:5 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:6 Changed 6 years ago by Owen Arnold
- Status changed from verifying to reopened
- Resolution fixed deleted
Generally I think you've done the right thing here, but there are some issues that I'd like to see fixed as part of this
- See the screenshot, if there is whitespace between run numbers, the user receives a wierd error. However, hit process a second time and it works?
- The TOF_run1_run2_run3 workspace gets generated even if it actually fails to find all the runs to load (see screenshot)
- Plus should be run as a child and then things should explicitly be pushed to the ADS when all operations have completed successfully (in my option)
- If not fixed elsewhere, I did not see units for Q on the what's this option.
comment:7 Changed 6 years ago by Harry Jeffery
- Status changed from reopened to inprogress
Refs #10516 Make run handling more robust
- Clean up any whitespace between each run before loading them
- Tidy up the ADS upon failure
Changeset: 84eca77fd4cce84e74b4a8357eb5acec85dbf7d8
comment:8 Changed 6 years ago by Harry Jeffery
Refs #10516 Handle single runs appropriately
Changeset: d9db2b5acb2b12a5690fc17a1fed02ef1b6633cd
comment:9 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
For now the Plus algorithm is going be kept as a regular algorithm, not a child, otherwise it doesn't preserve history. Long term this is definitely something that would be nice to address, but for now history preservation seems more valuable.
The units for Q are being addressed as part of #10536
comment:11 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10516_support_multiple_runs'
Full changeset: 03b564b9082d292ffe589b33f589db586dce23db
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11358
