Ticket #10534 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CreateWorkspace ignores user input for spectra axis values

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

This is only ever a problem when you need a spectrum numbers to be zero indexed, by default they are 1 indexed.

This is intentionally not possible and should give an error.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Blocking 9340 added

comment:2 Changed 6 years ago by Dan Nixon

  • Blocking 9340 removed

comment:3 Changed 6 years ago by Dan Nixon

  • Milestone changed from Release 3.3 to Backlog

I've managed to resolve the initial problem I had with this, and since it is intentionally not possible to set these values when using Spectra Axis I will change the purpose of this ticket to add validation that warns the user (/developer) when they try to do this.

comment:4 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add input validation to prevent entering spec axis values

Refs #10534

Changeset: ed93eaaf6519c3bbcbeaacbe1cc5c10b951b0623

comment:6 Changed 6 years ago by Dan Nixon

(wrong ticket number)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:7 Changed 6 years ago by Dan Nixon

(wrong ticket number)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:8 Changed 6 years ago by Dan Nixon

(wrong ticket number)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:9 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.3

comment:10 Changed 6 years ago by Dan Nixon

(wrong ticket number)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:11 Changed 6 years ago by Dan Nixon

(wrong ticket number)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:12 Changed 6 years ago by Dan Nixon

(wrong ticket number)

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:13 Changed 6 years ago by Dan Nixon

To test:

  • Open the CreateWorkspace algorithm interface
  • Enter a workspace name and some data (e.g. x=0,1,2,3, y=0,1,2)
  • Select SpectraNumber for VerticalAxisUnit
  • Enter some values in VerticalAxisValues
  • Run, this should fail validation and give an error on the VerticalAxisValues field
  • Removing any text in this field will allow the algorithm to execute properly

comment:14 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:15 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:16 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10534_createworkspace_spectraaxis_values_property'

Full changeset: 046e0c38fa933587961b42bfdec5421eb7b7b7f3

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11376

Note: See TracTickets for help on using tickets.