Ticket #10537 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Feature: Change inital view of Vates to be dependent on user and measurement specifications

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: critical Milestone: Release 3.3
Component: GUI Keywords: Vates
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The default intial view of Vates is currently set to the standard view.

This feature provides an initial view which depends on the technique with which the workspace data was measured. Additionally, the user can override this view selection by specifying a preferred initial view in the Mantid.user.properties file.

Attachments

Test script for initial view.docx (17.6 KB) - added by Anton Piccardo-Selg 6 years ago.
MDEvent_Osiris.nxs (2.3 MB) - added by Anton Piccardo-Selg 6 years ago.
MDHisto_Larmor.nxs (1.2 MB) - added by Anton Piccardo-Selg 6 years ago.
MDHisto_Osiris.nxs (164.6 KB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Owner set to Anton Piccardo-Selg
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from assigned to inprogress

Refs #10537 Added Technique-dependent initial view

Changeset: d7fae3d0dd68b093d5190d07493f61a086c287e2

comment:3 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Fixing issue with peak source

Changeset: 5d4c404f575da9f2a5d25e550fea99b08155d6ee

comment:4 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Fixing issue with view buttons

Changeset: d2b904cef1f3ef311fc2dedc7c0112818f606560

Changed 6 years ago by Anton Piccardo-Selg

Changed 6 years ago by Anton Piccardo-Selg

Changed 6 years ago by Anton Piccardo-Selg

Changed 6 years ago by Anton Piccardo-Selg

comment:5 Changed 6 years ago by Anton Piccardo-Selg

For Testing

Please find the test script and the test files in the attachment. The file MDHisto_Merlin.nxs is 8MB large and can therefore not be attached. I will share the file via email.

Code Review

Please review this code.

Most of the work is done in the MdViewerWidget, where we decide which initial view to select for a newly added workspace. The ModeSelectionWidget has been altered to handle the visibility of the view buttons slightly differently.

comment:6 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Keyword reserve was deleted

Changeset: 003be6d12f8446e80752ff3831b87a674b4affa3

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Removed hexahedron representation in vtkSplatterPlot

Changeset: 9b07a2da0bce9ddb854b6790fd67a961c267d3b9

comment:8 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 REvert changes on develop

Changeset: 445a5dce9040e7e11a028f921b48fd4c7cfc43e8

comment:9 Changed 6 years ago by Anton Piccardo-Selg

  • Priority changed from major to critical

comment:10 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Fix problems found by buildserver

Changeset: f0c54a684d92727dd0da49e4dc45c0e837747b98

comment:11 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Removed unused variables

Changeset: 9481f254aff3efa32334310a0437e74e609bd709

comment:12 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Fixing doxygen comments

Changeset: db09531efd5cc05a5c7a6effc08bfa8200fb5f5c

comment:13 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Fixing conversion to size_t

Changeset: 078d6c64312f7b08032bc3497d1b0b3f24ccc41e

comment:14 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Please see Comment 5 for testing

comment:15 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:16 Changed 6 years ago by Anton Piccardo-Selg

Refs #10537 Added more unit tests

Changeset: 19b251a1063156fa99076a09c59a6e01af42a198

comment:17 Changed 6 years ago by Pete Peterson

Re #10537. Running clang-format.

Changeset: 0f7810e769e7aea5ce5d717f83059eb12d0445eb

comment:18 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge commit 'a826649797ea37bf70aa8a1aef238ed6be442ad2' into feature/10537_variable_initial_view_vates

Full changeset: 47c45bf33515d0859b3ccdb1dd882d17435fb646

comment:19 Changed 6 years ago by Pete Peterson

Merge remote-tracking branch 'origin/master' into feature/10537_variable_initial_view_vates

Conflicts:

Code/Mantid/Framework/Kernel/inc/MantidKernel/ConfigService.h Code/Mantid/Framework/Kernel/src/ConfigService.cpp

Full changeset: 71fb268388875bc718ebcfdf969fa6086a333398

comment:20 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/10537_variable_initial_view_vates'

Full changeset: 5369bb41a85f04fdf68eb4fc59ad11aa1b5aa135

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11380

Note: See TracTickets for help on using tickets.