Ticket #10555 (closed: fixed)
Load HFIR HB2A data to MDWorkspace
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Andrei Savici |
Description
Change History
comment:7 Changed 6 years ago by Wenduo Zhou
Create algorithm files. Refs #10555.
Changeset: 62a46e6a343ab1c052e00cb898012de3f1a52400
comment:8 Changed 6 years ago by Wenduo Zhou
Implemented the algorithm and unit test. Refs #10555.
Changeset: 9d6c3aa90f3622ef90ea1aed85c6f37db5e2363c
comment:9 Changed 6 years ago by Wenduo Zhou
Added sphinx doc file. Refs #10555.
Changeset: cfa883af1bb0e12536a6616da22ad0ae4b8d0012
comment:10 Changed 6 years ago by Wenduo Zhou
Made some minor improvement. Refs #10555.
Changeset: 7c78975128acfd4ad241a99643988ceb9a6c1475
comment:11 Changed 6 years ago by Wenduo Zhou
Tried to fix a cppcheck error. Refs #10555.
Changeset: 5261afd73f86933bc3775b74f19caf75fa3bbc8a
comment:12 Changed 6 years ago by Wenduo Zhou
Fixed 2 doxygen error. Refs #10555.
Changeset: 2802ddfe1b499ee41e7b5fb9285c5faf773860dd
comment:13 Changed 6 years ago by Wenduo Zhou
Cleaned the codes and improved unit tests. Refs #10555.
Changeset: a7ee2e0932fca17f555207d10dbdf423ef239b61
comment:14 Changed 6 years ago by Wenduo Zhou
Refs #10555. Fixed doxygen and cppcheck error.
And made changes to sample logs of the output MDWorkspace.
On branch feature/10555_hb2a_mdws
- modified: ../Mantid/Framework/MDAlgorithms/inc/MantidMDAlgorithms/LoadHFIRPDData.h
- modified: ../Mantid/Framework/MDAlgorithms/src/LoadHFIRPDData.cpp
- modified: ../Mantid/docs/source/algorithms/LoadHFIRPDData-v1.rst
Changeset: 99cb3c116bf4b9e3c67cb15ba90c4efa0d80d84a
comment:15 Changed 6 years ago by Wenduo Zhou
Fixed 2 cppcheck errors and 1 doxygen one. Refs #10555.
Changeset: 08925dc03bc477508a56f557dba86001ddc48423
comment:16 Changed 6 years ago by Wenduo Zhou
Removed the hardcoded log names. Refs #10555.
Changeset: fc47f4333f3af65bd28a30e55e7a37f6a8267c67
comment:17 Changed 6 years ago by Wenduo Zhou
Improved doxygen of the algorith. Refs #10555.
Changeset: f93301de61d474d20c45ce125296a4a00119888c
comment:18 Changed 6 years ago by Wenduo Zhou
Refs #10555. Re-implement how to add sample logs.
Refined how to add sample logs to the generated MDWorkspaces. And expanded the unit test for the sample logs.
Changeset: 8760e656b0a2e887762371678c680faf812b94b8
comment:19 Changed 6 years ago by Wenduo Zhou
Fixed some warnings. Refs #10555.
Changeset: bc935622ce5098d24aec81899101c4c00976006c
comment:20 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #182.
comment:21 Changed 6 years ago by Wenduo Zhou
For tester
Please run the following script and take a look into the MDWorkspaces generated.
LoadSpiceAscii(Filename='HB2A_exp0231_scan0001.dat', DateAndTimeLog='date,MM/DD/YYYY,time,HH:MM:SS AM', OutputWorkspace='Exp0231DataTable', RunInfoWorkspace='Exp0231ParentWS') LoadHFIRPDData(InputWorkspace='Exp0231DataTable', ParentWorkspace='Exp0231ParentWS', OutputWorkspace='Exp0231DataMD', OutputMonitorWorkspace='Exp0231MonitorMD')
The SPICE file can be found in .../Mantid/Test/AutoTestData/
comment:22 Changed 6 years ago by Wenduo Zhou
retest this please.
comment:23 Changed 6 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:24 Changed 6 years ago by Wenduo Zhou
Refs #10555. Fixed a critical error on run and detid.
A critical error is fixed on the run ID and detector ID in the MDEventWrokspaces.
More unit tests are added to ensure that the rotation of the detectors are reflected in the MDEventWorkspaces.
Property InitRunNumber is removed and replaced by using Pt. value in the SPICE file.
Documentation is modified for better understanding.
Changeset: 18913e5120892216e51a27fcfd7e9babe38cd2ed
comment:25 Changed 6 years ago by Wenduo Zhou
Refs #10555. Fixed 2 cppcheck warnings.
Changeset: ad299a82230dbbc2118f0f8eff5c9af2ad49a134
comment:26 Changed 6 years ago by Wenduo Zhou
Fixed some doxygen issues. Refs #10555.
Changeset: 9faa6140ca5d533d411ad68127ab27f1442a2842
comment:27 Changed 6 years ago by Wenduo Zhou
Fixed 2 compiling warning. Refs #10555.
Changeset: 2178391a9bc4f56c6157553242e9ca49b491baf0
comment:28 Changed 6 years ago by Andrei Savici
Looks much better. But the name is wrong. It is not a Load algoruthm, it is a Convert... type of algorithm.
comment:29 Changed 6 years ago by Wenduo Zhou
Refs #10555. Renamed algorithm to ConvertSpiceDataToRealSpace.
From LoadHFIRPDData
Changeset: 5722c024db3efffeb5fb11b3491d415e3e1f8ab7
comment:30 Changed 6 years ago by Wenduo Zhou
Changed input property name. Refs #10555.
Changeset: 74205499955f7e23c3fdde7c4212b1fa2a08decd
comment:31 Changed 6 years ago by Andrei Savici
There is a lot more to do with documentation
comment:32 Changed 6 years ago by Andrei Savici
- Status changed from verifying to closed
Merge pull request #182 from mantidproject/feature/10555_hb2a_mdws
Feature/10555 hb2a mdws
Full changeset: 375bc26198b309bf7cd19214876156b870a882ce
comment:33 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:34 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11397
