Ticket #10562 (closed: fixed)
[IDR] ET ignores calibration files
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 3.3 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@…, sanghamitra.mukhopadhyay@… | Blocked By: | |
| Blocking: | Tester: | Federico M Pouzols |
Description
If giving a calibration file to IDR > ET it is not passed to the algorithm, hence reductions using this interface will not be corrected using the calibration run.
Attachments
Change History
comment:1 Changed 6 years ago by Dan Nixon
- Status changed from new to assigned
- Component changed from Framework to Indirect Inelastic
comment:2 Changed 6 years ago by Dan Nixon
- Summary changed from [IDR] ET ignores clibration files to [IDR] ET ignores calibration files
comment:5 Changed 6 years ago by Dan Nixon
Populate calib filename with saved file from Calib tab
Refs #10562
Changeset: 2112c7d2d3885efc05b33e1239679d5f8d37e475
comment:6 Changed 6 years ago by Dan Nixon
To test:
- Open IDR > Calib
- Load IRS26176, check Save, Run
- Switch to Energy Transfer tab
- Calibration workspace name should be populated and Use Calib file selected
- Load run IRS27173, select plot contour, Run
- Check plot looks similar to Calib.pdf, data should be almost constant
- Disable Use Calib file and run again
- Check plot against notCalib.pdf
comment:7 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:9 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:10 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10562_idr_et_ignores_calib_files'
Full changeset: a27f52dbc46fd8a087f5ac6b57e57ed41bd84dc4
comment:11 Changed 6 years ago by Federico M Pouzols
Works well. Depending on what file I use for calibration I get different results, and for IRS21173 I get an identical contour plot. New code adds the missing functionality.
These IDR tabs may need a bit of improvement in error checking. It is relatively easy to make the IDR interface crash if you hit the run buttons in the wrong moment or populate fields in a wrong sequence.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11404
