Context Navigation

Ticket #10611 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Calculate coverage for direct geometry

Reported by:	Andrei Savici	Owned by:	Andrei Savici
Priority:	critical	Milestone:	Release 3.3
Component:	Direct Inelastic	Keywords:
Cc:		Blocked By:
Blocking:	#9105, #9304, #10698, #11222	Tester:	Stuart Campbell

Description

This will create an algorithm to calculate the exact coverage in reciprocal space for direct geometry measurements. It will be also the basis for MDNormDGS

Change History

comment:1 Changed 6 years ago by Andrei Savici

Status changed from new to assigned

This could be used in #9304

comment:2 Changed 6 years ago by Andrei Savici

Status changed from assigned to inprogress

Start work on DGS coverage. Refs #10611

Changeset: eb348e5de79d2bf1bfa061397ac5a637690faf47

comment:3 Changed 6 years ago by Andrei Savici

rst file. refs #10611

Changeset: afb124bd4296493bc9a17fcec6dec6e95c530f9b

comment:4 Changed 6 years ago by Andrei Savici

A few properties and calculations. Refs #10611

Changeset: 04f5d87b21060f33eded148044c673fa2950f4e5

comment:5 Changed 6 years ago by Andrei Savici

More input processing. Refs #10611

Changeset: fdffcb26234552a1bbf1d536626c464a725ad76f

comment:6 Changed 6 years ago by Andrei Savici

Use intersections to update coverage. Refs #10611

Changeset: 6cb9143082f1bfb782b516ec488aa20325639ccb

comment:7 Changed 6 years ago by Andrei Savici

Intersections with H planes. Refs #10611

Changeset: e628d664606944dfbf90850a082caa069a35e952

comment:8 Changed 6 years ago by Andrei Savici

Intersections with k and l planes. refs #10611

Changeset: 0369a4a46d772e13ed67fd20ab5109aad2d4bd87

comment:9 Changed 6 years ago by Andrei Savici

Test and documentation. Refs #10611

Changeset: cff9c73dc61806bb2fdaccc341d4969163d8498d

comment:10 Changed 6 years ago by Andrei Savici

Fix doctest. Refs #10611

Changeset: c8cf1d6d1e7c32c6c9cbe2e8f6af5be7541309cb

comment:11 Changed 6 years ago by Andrei Savici

Move constant from header to cpp. Refs #10611

Changeset: 48bbbdf5111a8dae39b89016a74461755fb5fdcd

comment:12 Changed 6 years ago by Andrei Savici

Status changed from inprogress to verify
Resolution set to fixed

To test: see usage example. Create a matrix workspace for a direct geometry instrument, that contains Ei, goniometer, and UB. Check if the output of CalculateCoverageDGS is consistent with what you get from ConvertToMD

comment:13 Changed 6 years ago by Raquel Alvarez Banos

Status changed from verify to verifying
Tester set to Raquel Alvarez Banos

comment:14 Changed 6 years ago by Raquel Alvarez Banos

Status changed from verifying to reopened
Resolution fixed deleted

Hi Andrei, I get this error when doing git test start, so I am reopening the ticket.

ERROR: Branch 'feature/10611_DGS_coverage' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.

Contact Andrei Savici on saviciat@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10611_DGS_coverage and let you know when it passes testing on the buildservers so you can start testing.

Last edited 6 years ago by Raquel Alvarez Banos (previous) (diff)